Azure / azure-iot-sdk-c

A C99 SDK for connecting devices to Microsoft Azure IoT services
https://azure.github.io/azure-iot-sdk-c
Other
585 stars 739 forks source link

Version 1.12.0 does not have a git tag #2560

Closed Timple closed 7 months ago

Timple commented 7 months ago

The template is a bit verbose, but version 1.12.0 does not have a git tag: https://github.com/Azure/azure-iot-sdk-c/tags

The other versions do. Can this be corrected?

ericwolz commented 7 months ago

1.12.0 has not been release yet. Current version is 1.11

https://github.com/Azure/azure-iot-sdk-c/releases/tag/LTS_08_2023

Timple commented 7 months ago

Aah, my bad.

Timple commented 7 months ago

But on the same note. Where is the 1.11 tag?

ericwolz commented 7 months ago

We are no longer creating a version tag, only the LTS tag. They both point to the same thing.

Timple commented 7 months ago

Ah that is a pitty. Your version.txt does show the three digit version number. So that is how our tooling correlates this with the releases.

Would it be a burden to add these tags? Otherwise we (and potentially others) need to maintain a shadow list of which tag corresponds to which version.

besquivel-pivotal commented 7 months ago

Ah that is a pitty. Your version.txt does show the three digit version number. So that is how our tooling correlates this with the releases.

Would it be a burden to add these tags? Otherwise we (and potentially others) need to maintain a shadow list of which tag corresponds to which version.

The tags used to be there. Our build references the version that is written in version.txt and it recently started failing because the 1.11.0 tag was removed.

@ericwol-msft, it would be a tremendous help if you kept the tags that were already created.

RLeclair commented 7 months ago

Hi @besquivel-pivotal, I've gone ahead and added the 1.11.0 tag and added the 1.12.0 tag. Closing the issue now

Timple commented 7 months ago

Thank you!