Azure / azure-iot-sdk-c

A C99 SDK for connecting devices to Microsoft Azure IoT services
https://azure.github.io/azure-iot-sdk-c
Other
580 stars 738 forks source link

Fix another edge case in Azure callbacks handling #2607

Closed pulkomandy closed 2 months ago

pulkomandy commented 3 months ago

Checklist

Reference/Link to the issue solved with this PR (if any)

2569

Description of the problem

The previous fix for bug 2569 missed an edge case where the upload is succesful but the notification is not. In that case, there would be a success callback followed by an error one, which is not expected (the success callback should be the last one).

Description of the solution

Delay the success callback until the return of the upload function, in case errors happen in the late stage of the upload to blob.

pulkomandy commented 3 months ago

@microsoft-github-policy-service agree company="Viveris Technologies"

ewertons commented 2 months ago

This PR has been replaced by https://github.com/Azure/azure-iot-sdk-c/pull/2615 Thanks, Azure IoT SDKs Team.