search

Azure / azure-iot-sdk-c

A C99 SDK for connecting devices to Microsoft Azure IoT services
https://azure.github.io/azure-iot-sdk-c
Other
588 stars 737 forks source link

GCC 8.2 generates warnings when compiling serializer/src/commanddecoder.c #587

Closed pboettch closed 6 years ago

pboettch commented 6 years ago

Related issue: https://github.com/Azure/azure-c-shared-utility/issues/174

When compiling serializer/src/commanddecoder.c with 

gcc (Debian 8.2.0-3) 8.2.0

I'm getting warnings (and thus errors (-Werror)) due the use of strncpy. GCC is unable to figure out that the length-arg is correctly guarded (or is it not)?

In function ‘DecodeAndExecuteModelAction.isra.0’,
    inlined from ‘ScanActionPathAndExecuteAction’ at azure-iot-sdk-c/serializer/src/commanddecoder.c:441:26,
    inlined from ‘DecodeCommand’ at azure-iot-sdk-c/serializer/src/commanddecoder.c:607:22,
    inlined from ‘CommandDecoder_ExecuteCommand’ at azure-iot-sdk-c/serializer/src/commanddecoder.c:679:26:
azure-iot-sdk-c/serializer/src/commanddecoder.c:194:13: error: ‘strncpy’ specified bound depends on the length of the source argument [-Werror=stringop-overflow=]
         if (strncpy(tempStr, actionName, strLength - 1) == NULL)
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
azure-iot-sdk-c/serializer/src/commanddecoder.c: In function ‘CommandDecoder_ExecuteCommand’:
azure-iot-sdk-c/serializer/src/commanddecoder.c:176:24: note: length computed here
     size_t strLength = strlen(actionName);

strncpy() could be replace with memcpy() here, I think.

ewertons commented 6 years ago

Hi @pboettch ,

could you tell us the version of the Azure IoT C SDK you are using, and the specific version of gcc you are using?

Also, what are all the command lines you typed and the output?

ewertons commented 6 years ago

For reference, I am not getting the failure you are mentioning.

Version of the C SDK used: master@8/21/2018 (commit id ab8f6d731b6583f9de9571b666590db92b285799)

ewertons@debian820:~/azure-iot-sdk-c/cmake$ cmake ..
-- The C compiler identification is GNU 4.9.2
-- The CXX compiler identification is GNU 4.9.2
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- IoT Client SDK Version = 1.2.8
-- Provisioning client OFF
-- Looking for include file stdint.h
-- Looking for include file stdint.h - found
-- Looking for include file stdbool.h
-- Looking for include file stdbool.h - found
-- Looking for __x86_64__
-- Looking for __x86_64__ - found
-- target architecture: x86_64
-- Performing Test CXX_FLAG_CXX11
-- Performing Test CXX_FLAG_CXX11 - Success
-- Found OpenSSL: /usr/lib/x86_64-linux-gnu/libssl.so;/usr/lib/x86_64-linux-gnu/libcrypto.so (found version "1.0.1t")
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.28")
-- checking for module 'libcurl'
--   found libcurl, version 7.38.0
-- Found CURL: curl
-- target architecture: x86_64
-- target architecture: x86_64
-- target architecture: x86_64
-- target architecture: x86_64
-- iothub architecture: x86_64
-- Configuring done
-- Generating done
-- Build files have been written to: /home/ewertons/azure-iot-sdk-c/cmake
ewertons@debian820:~/azure-iot-sdk-c/cmake$
ewertons@debian820:~/azure-iot-sdk-c/cmake$ ls_release -a
-bash: ls_release: command not found
ewertons@debian820:~/azure-iot-sdk-c/cmake$ uname -a
Linux debian820 3.16.0-4-amd64 #1 SMP Debian 3.16.51-3 (2017-12-13) x86_64 GNU/Linux
ewertons@debian820:~/azure-iot-sdk-c/cmake$ gcc --version
gcc (Debian 4.9.2-10+deb8u1) 4.9.2
Copyright (C) 2014 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

ewertons@debian820:~/azure-iot-sdk-c/cmake$
ewertons@debian820:~/azure-iot-sdk-c/cmake$
ewertons@debian820:~/azure-iot-sdk-c/cmake$
ewertons@debian820:~/azure-iot-sdk-c/cmake$ make -j `nproc`
Scanning dependencies of target parson
[  0%] Building C object CMakeFiles/parson.dir/deps/parson/parson.c.o
Linking C static library libparson.a
[  0%] Built target parson
Scanning dependencies of target aziotsharedutil
[  0%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/base32.c.o
[  1%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/base64.c.o
[  1%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/buffer.c.o
[  2%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/connection_string_parser.c.o
[  2%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/constbuffer.c.o
[  3%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/consolelogger.c.o
[  3%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/crt_abstractions.c.o
[  4%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/constmap.c.o
[  4%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/doublylinkedlist.c.o
[  5%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/gballoc.c.o
[  5%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/gbnetwork.c.o
[  6%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/gb_stdio.c.o
[  6%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/gb_time.c.o
[  7%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/gb_rand.c.o
[  7%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/hmac.c.o
[  8%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/hmacsha256.c.o
[  8%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/http_proxy_io.c.o
[  9%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/xio.c.o
[  9%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/singlylinkedlist.c.o
[ 10%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/map.c.o
[ 10%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/sastoken.c.o
[ 11%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/sha1.c.o
[ 11%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/sha224.c.o
[ 12%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/sha384-512.c.o
[ 12%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/strings.c.o
[ 13%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/string_tokenizer.c.o
[ 13%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/uuid.c.o
[ 14%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/urlencode.c.o
[ 14%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/usha.c.o
[ 15%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/vector.c.o
[ 15%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/xlogging.c.o
[ 16%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/optionhandler.c.o
[ 16%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/adapters/agenttime.c.o
[ 17%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/adapters/condition_pthreads.c.o
[ 17%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/adapters/lock_pthreads.c.o
[ 18%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/adapters/platform_linux.c.o
[ 18%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/adapters/socketio_berkeley.c.o
[ 19%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/adapters/tickcounter_linux.c.o
[ 19%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/adapters/threadapi_pthreads.c.o
[ 20%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/adapters/uniqueid_linux.c.o
[ 20%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/adapters/envvariable.c.o
[ 21%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/adapters/linux_time.c.o
[ 21%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/httpapiex.c.o
[ 22%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/httpapiexsas.c.o
[ 22%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/httpheaders.c.o
[ 23%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/adapters/httpapi_curl.c.o
[ 23%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/adapters/tlsio_openssl.c.o
[ 24%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/adapters/x509_openssl.c.o
[ 24%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/wsio.c.o
[ 25%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/uws_client.c.o
[ 25%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/uws_frame_encoder.c.o
[ 26%] Building C object c-utility/CMakeFiles/aziotsharedutil.dir/src/utf8_checker.c.o
Linking C static library libaziotsharedutil.a
[ 26%] Built target aziotsharedutil
Scanning dependencies of target uamqp
[ 27%] Building C object uamqp/CMakeFiles/uamqp.dir/src/amqp_definitions.c.o
[ 27%] Building C object uamqp/CMakeFiles/uamqp.dir/src/amqp_frame_codec.c.o
[ 28%] Building C object uamqp/CMakeFiles/uamqp.dir/src/amqp_management.c.o
[ 28%] Building C object uamqp/CMakeFiles/uamqp.dir/src/amqpvalue.c.o
[ 29%] Building C object uamqp/CMakeFiles/uamqp.dir/src/amqpvalue_to_string.c.o
[ 29%] Building C object uamqp/CMakeFiles/uamqp.dir/src/async_operation.c.o
[ 30%] Building C object uamqp/CMakeFiles/uamqp.dir/src/cbs.c.o
[ 30%] Building C object uamqp/CMakeFiles/uamqp.dir/src/connection.c.o
[ 31%] Building C object uamqp/CMakeFiles/uamqp.dir/src/frame_codec.c.o
[ 31%] Building C object uamqp/CMakeFiles/uamqp.dir/src/header_detect_io.c.o
[ 32%] Building C object uamqp/CMakeFiles/uamqp.dir/src/link.c.o
[ 32%] Building C object uamqp/CMakeFiles/uamqp.dir/src/message.c.o
[ 33%] Building C object uamqp/CMakeFiles/uamqp.dir/src/message_receiver.c.o
[ 33%] Building C object uamqp/CMakeFiles/uamqp.dir/src/message_sender.c.o
[ 34%] Building C object uamqp/CMakeFiles/uamqp.dir/src/messaging.c.o
[ 34%] Building C object uamqp/CMakeFiles/uamqp.dir/src/sasl_anonymous.c.o
[ 35%] Building C object uamqp/CMakeFiles/uamqp.dir/src/sasl_frame_codec.c.o
[ 35%] Building C object uamqp/CMakeFiles/uamqp.dir/src/sasl_mechanism.c.o
[ 36%] Building C object uamqp/CMakeFiles/uamqp.dir/src/sasl_server_mechanism.c.o
[ 36%] Building C object uamqp/CMakeFiles/uamqp.dir/src/sasl_mssbcbs.c.o
[ 37%] Building C object uamqp/CMakeFiles/uamqp.dir/src/sasl_plain.c.o
[ 37%] Building C object uamqp/CMakeFiles/uamqp.dir/src/saslclientio.c.o
[ 38%] Building C object uamqp/CMakeFiles/uamqp.dir/src/session.c.o
[ 38%] Building C object uamqp/CMakeFiles/uamqp.dir/src/socket_listener_berkeley.c.o
Linking C static library libuamqp.a
[ 38%] Built target uamqp
Scanning dependencies of target umqtt
[ 38%] Building C object umqtt/CMakeFiles/umqtt.dir/src/mqtt_client.c.o
[ 39%] Building C object umqtt/CMakeFiles/umqtt.dir/src/mqtt_codec.c.o
[ 40%] Building C object umqtt/CMakeFiles/umqtt.dir/src/mqtt_message.c.o
Linking C static library libumqtt.a
[ 40%] Built target umqtt
Scanning dependencies of target uhttp
[ 41%] Building C object deps/uhttp/CMakeFiles/uhttp.dir/src/uhttp.c.o
Linking C static library libuhttp.a
[ 41%] Built target uhttp
Scanning dependencies of target iothub_service_client
[ 42%] Building C object iothub_service_client/CMakeFiles/iothub_service_client.dir/src/iothub_deviceconfiguration.c.o
[ 42%] Building C object iothub_service_client/CMakeFiles/iothub_service_client.dir/src/iothub_devicemethod.c.o
[ 43%] Building C object iothub_service_client/CMakeFiles/iothub_service_client.dir/src/iothub_devicetwin.c.o
[ 43%] Building C object iothub_service_client/CMakeFiles/iothub_service_client.dir/src/iothub_messaging.c.o
[ 44%] Building C object iothub_service_client/CMakeFiles/iothub_service_client.dir/src/iothub_messaging_ll.c.o
[ 44%] Building C object iothub_service_client/CMakeFiles/iothub_service_client.dir/src/iothub_registrymanager.c.o
[ 45%] Building C object iothub_service_client/CMakeFiles/iothub_service_client.dir/src/iothub_sc_version.c.o
[ 45%] Building C object iothub_service_client/CMakeFiles/iothub_service_client.dir/src/iothub_service_client_auth.c.o
[ 46%] Building C object iothub_service_client/CMakeFiles/iothub_service_client.dir/__/iothub_client/src/iothub_message.c.o
Linking C static library libiothub_service_client.a
[ 46%] Built target iothub_service_client
Scanning dependencies of target iothub_deviceconfiguration_sample
[ 47%] Building C object iothub_service_client/samples/iothub_deviceconfiguration_sample/CMakeFiles/iothub_deviceconfiguration_sample.dir/iothub_deviceconfiguration_sample.c.o
Linking C executable iothub_deviceconfiguration_sample
[ 47%] Built target iothub_deviceconfiguration_sample
Scanning dependencies of target iothub_devicemethod_sample
[ 47%] Building C object iothub_service_client/samples/iothub_devicemethod_sample/CMakeFiles/iothub_devicemethod_sample.dir/iothub_devicemethod_sample.c.o
Linking C executable iothub_devicemethod_sample
[ 47%] Built target iothub_devicemethod_sample
Scanning dependencies of target iothub_devicetwin_sample
[ 48%] Building C object iothub_service_client/samples/iothub_devicetwin_sample/CMakeFiles/iothub_devicetwin_sample.dir/iothub_devicetwin_sample.c.o
Linking C executable iothub_devicetwin_sample
[ 48%] Built target iothub_devicetwin_sample
Scanning dependencies of target iothub_messaging_sample
[ 49%] Building C object iothub_service_client/samples/iothub_messaging_sample/CMakeFiles/iothub_messaging_sample.dir/iothub_messaging_sample.c.o
Linking C executable iothub_messaging_sample
[ 49%] Built target iothub_messaging_sample
Scanning dependencies of target iothub_messaging_ll_sample
[ 49%] Building C object iothub_service_client/samples/iothub_messaging_ll_sample/CMakeFiles/iothub_messaging_ll_sample.dir/iothub_messaging_ll_sample.c.o
Linking C executable iothub_messaging_ll_sample
[ 49%] Built target iothub_messaging_ll_sample
Scanning dependencies of target iothub_registrymanager_sample
[ 49%] Building C object iothub_service_client/samples/iothub_registrymanager_sample/CMakeFiles/iothub_registrymanager_sample.dir/iothub_registrymanager_sample.c.o
Linking C executable iothub_registrymanager_sample
[ 49%] Built target iothub_registrymanager_sample
Scanning dependencies of target iothub_client_mqtt_ws_transport
[ 50%] Building C object iothub_client/CMakeFiles/iothub_client_mqtt_ws_transport.dir/src/iothub_client_authorization.c.o
[ 50%] Building C object iothub_client/CMakeFiles/iothub_client_mqtt_ws_transport.dir/src/iothub_client_retry_control.c.o
[ 51%] Building C object iothub_client/CMakeFiles/iothub_client_mqtt_ws_transport.dir/src/iothubtransport_mqtt_common.c.o
[ 51%] Building C object iothub_client/CMakeFiles/iothub_client_mqtt_ws_transport.dir/src/iothubtransportmqtt_websockets.c.o
Linking C static library libiothub_client_mqtt_ws_transport.a
[ 51%] Built target iothub_client_mqtt_ws_transport
Scanning dependencies of target iothub_client_http_transport
[ 51%] Building C object iothub_client/CMakeFiles/iothub_client_http_transport.dir/src/iothub_client_authorization.c.o
[ 52%] Building C object iothub_client/CMakeFiles/iothub_client_http_transport.dir/src/iothub_client_retry_control.c.o
[ 52%] Building C object iothub_client/CMakeFiles/iothub_client_http_transport.dir/src/iothubtransporthttp.c.o
Linking C static library libiothub_client_http_transport.a
[ 52%] Built target iothub_client_http_transport
Scanning dependencies of target iothub_client_amqp_transport
[ 53%] Building C object iothub_client/CMakeFiles/iothub_client_amqp_transport.dir/src/iothub_client_authorization.c.o
[ 53%] Building C object iothub_client/CMakeFiles/iothub_client_amqp_transport.dir/src/iothub_client_retry_control.c.o
[ 54%] Building C object iothub_client/CMakeFiles/iothub_client_amqp_transport.dir/src/iothubtransport_amqp_common.c.o
[ 54%] Building C object iothub_client/CMakeFiles/iothub_client_amqp_transport.dir/src/iothubtransport_amqp_device.c.o
[ 55%] Building C object iothub_client/CMakeFiles/iothub_client_amqp_transport.dir/src/iothubtransport_amqp_cbs_auth.c.o
[ 55%] Building C object iothub_client/CMakeFiles/iothub_client_amqp_transport.dir/src/iothubtransport_amqp_connection.c.o
[ 56%] Building C object iothub_client/CMakeFiles/iothub_client_amqp_transport.dir/src/iothubtransport_amqp_telemetry_messenger.c.o
[ 56%] Building C object iothub_client/CMakeFiles/iothub_client_amqp_transport.dir/src/iothubtransport_amqp_twin_messenger.c.o
[ 57%] Building C object iothub_client/CMakeFiles/iothub_client_amqp_transport.dir/src/iothubtransport_amqp_messenger.c.o
[ 57%] Building C object iothub_client/CMakeFiles/iothub_client_amqp_transport.dir/src/iothubtransportamqp_methods.c.o
[ 58%] Building C object iothub_client/CMakeFiles/iothub_client_amqp_transport.dir/src/message_queue.c.o
[ 58%] Building C object iothub_client/CMakeFiles/iothub_client_amqp_transport.dir/src/uamqp_messaging.c.o
[ 59%] Building C object iothub_client/CMakeFiles/iothub_client_amqp_transport.dir/src/iothubtransportamqp.c.o
Linking C static library libiothub_client_amqp_transport.a
[ 59%] Built target iothub_client_amqp_transport
Scanning dependencies of target iothub_client_mqtt_transport
[ 60%] Building C object iothub_client/CMakeFiles/iothub_client_mqtt_transport.dir/src/iothub_client_authorization.c.o
[ 60%] Building C object iothub_client/CMakeFiles/iothub_client_mqtt_transport.dir/src/iothub_client_retry_control.c.o
[ 61%] Building C object iothub_client/CMakeFiles/iothub_client_mqtt_transport.dir/src/iothubtransport_mqtt_common.c.o
[ 61%] Building C object iothub_client/CMakeFiles/iothub_client_mqtt_transport.dir/src/iothubtransportmqtt.c.o
Linking C static library libiothub_client_mqtt_transport.a
[ 61%] Built target iothub_client_mqtt_transport
Scanning dependencies of target iothub_client_amqp_ws_transport
[ 61%] Building C object iothub_client/CMakeFiles/iothub_client_amqp_ws_transport.dir/src/iothub_client_authorization.c.o
[ 62%] Building C object iothub_client/CMakeFiles/iothub_client_amqp_ws_transport.dir/src/iothub_client_retry_control.c.o
[ 62%] Building C object iothub_client/CMakeFiles/iothub_client_amqp_ws_transport.dir/src/iothubtransport_amqp_common.c.o
[ 63%] Building C object iothub_client/CMakeFiles/iothub_client_amqp_ws_transport.dir/src/iothubtransport_amqp_device.c.o
[ 63%] Building C object iothub_client/CMakeFiles/iothub_client_amqp_ws_transport.dir/src/iothubtransport_amqp_cbs_auth.c.o
[ 64%] Building C object iothub_client/CMakeFiles/iothub_client_amqp_ws_transport.dir/src/iothubtransport_amqp_connection.c.o
[ 64%] Building C object iothub_client/CMakeFiles/iothub_client_amqp_ws_transport.dir/src/iothubtransport_amqp_telemetry_messenger.c.o
[ 65%] Building C object iothub_client/CMakeFiles/iothub_client_amqp_ws_transport.dir/src/iothubtransport_amqp_twin_messenger.c.o
[ 65%] Building C object iothub_client/CMakeFiles/iothub_client_amqp_ws_transport.dir/src/iothubtransport_amqp_messenger.c.o
[ 66%] Building C object iothub_client/CMakeFiles/iothub_client_amqp_ws_transport.dir/src/iothubtransportamqp_methods.c.o
[ 66%] Building C object iothub_client/CMakeFiles/iothub_client_amqp_ws_transport.dir/src/message_queue.c.o
[ 67%] Building C object iothub_client/CMakeFiles/iothub_client_amqp_ws_transport.dir/src/uamqp_messaging.c.o
[ 67%] Building C object iothub_client/CMakeFiles/iothub_client_amqp_ws_transport.dir/src/iothubtransportamqp_websockets.c.o
Linking C static library libiothub_client_amqp_ws_transport.a
[ 67%] Built target iothub_client_amqp_ws_transport
Scanning dependencies of target iothub_client
[ 67%] Building C object iothub_client/CMakeFiles/iothub_client.dir/src/iothub.c.o
[ 68%] Building C object iothub_client/CMakeFiles/iothub_client.dir/src/iothub_client.c.o
[ 68%] Building C object iothub_client/CMakeFiles/iothub_client.dir/src/iothub_client_core.c.o
[ 69%] Building C object iothub_client/CMakeFiles/iothub_client.dir/src/iothub_client_core_ll.c.o
[ 69%] Building C object iothub_client/CMakeFiles/iothub_client.dir/src/iothub_client_diagnostic.c.o
[ 70%] Building C object iothub_client/CMakeFiles/iothub_client.dir/src/iothub_client_ll.c.o
[ 70%] Building C object iothub_client/CMakeFiles/iothub_client.dir/src/iothub_device_client.c.o
[ 71%] Building C object iothub_client/CMakeFiles/iothub_client.dir/src/iothub_device_client_ll.c.o
[ 71%] Building C object iothub_client/CMakeFiles/iothub_client.dir/src/iothub_message.c.o
[ 72%] Building C object iothub_client/CMakeFiles/iothub_client.dir/src/iothub_module_client.c.o
[ 72%] Building C object iothub_client/CMakeFiles/iothub_client.dir/src/iothub_module_client_ll.c.o
[ 73%] Building C object iothub_client/CMakeFiles/iothub_client.dir/src/iothubtransport.c.o
[ 73%] Building C object iothub_client/CMakeFiles/iothub_client.dir/src/version.c.o
[ 74%] Building C object iothub_client/CMakeFiles/iothub_client.dir/src/iothub_client_ll_uploadtoblob.c.o
[ 74%] Building C object iothub_client/CMakeFiles/iothub_client.dir/src/blob.c.o
Linking C static library libiothub_client.a
[ 74%] Built target iothub_client
Scanning dependencies of target iothub_convenience_sample
[ 75%] Building C object iothub_client/samples/iothub_convenience_sample/CMakeFiles/iothub_convenience_sample.dir/iothub_convenience_sample.c.o
[ 75%] Building C object iothub_client/samples/iothub_convenience_sample/CMakeFiles/iothub_convenience_sample.dir/__/__/__/certs/certs.c.o
Linking C executable iothub_convenience_sample
[ 75%] Built target iothub_convenience_sample
Scanning dependencies of target iothub_ll_c2d_sample
[ 75%] Building C object iothub_client/samples/iothub_ll_c2d_sample/CMakeFiles/iothub_ll_c2d_sample.dir/iothub_ll_c2d_sample.c.o
[ 76%] Building C object iothub_client/samples/iothub_ll_c2d_sample/CMakeFiles/iothub_ll_c2d_sample.dir/__/__/__/certs/certs.c.o
Linking C executable iothub_ll_c2d_sample
[ 76%] Built target iothub_ll_c2d_sample
Scanning dependencies of target iothub_ll_client_x509_sample
[ 76%] Building C object iothub_client/samples/iothub_ll_client_x509_sample/CMakeFiles/iothub_ll_client_x509_sample.dir/iothub_ll_client_x509_sample.c.o
[ 77%] Building C object iothub_client/samples/iothub_ll_client_x509_sample/CMakeFiles/iothub_ll_client_x509_sample.dir/__/__/__/certs/certs.c.o
Linking C executable iothub_ll_client_x509_sample
[ 77%] Built target iothub_ll_client_x509_sample
Scanning dependencies of target iothub_ll_telemetry_sample
[ 77%] Building C object iothub_client/samples/iothub_ll_telemetry_sample/CMakeFiles/iothub_ll_telemetry_sample.dir/iothub_ll_telemetry_sample.c.o
[ 78%] Building C object iothub_client/samples/iothub_ll_telemetry_sample/CMakeFiles/iothub_ll_telemetry_sample.dir/__/__/__/certs/certs.c.o
Linking C executable iothub_ll_telemetry_sample
[ 78%] Built target iothub_ll_telemetry_sample
Scanning dependencies of target iothub_client_sample_upload_to_blob
[ 79%] Building C object iothub_client/samples/iothub_client_sample_upload_to_blob/CMakeFiles/iothub_client_sample_upload_to_blob.dir/iothub_client_sample_upload_to_blob.c.o
[ 79%] Building C object iothub_client/samples/iothub_client_sample_upload_to_blob/CMakeFiles/iothub_client_sample_upload_to_blob.dir/__/__/__/certs/certs.c.o
Linking C executable iothub_client_sample_upload_to_blob
[ 79%] Built target iothub_client_sample_upload_to_blob
Scanning dependencies of target iothub_client_sample_upload_to_blob_mb
[ 80%] Building C object iothub_client/samples/iothub_client_sample_upload_to_blob_mb/CMakeFiles/iothub_client_sample_upload_to_blob_mb.dir/iothub_client_sample_upload_to_blob_mb.c.o
[ 80%] Building C object iothub_client/samples/iothub_client_sample_upload_to_blob_mb/CMakeFiles/iothub_client_sample_upload_to_blob_mb.dir/__/__/__/certs/certs.c.o
Linking C executable iothub_client_sample_upload_to_blob_mb
[ 80%] Built target iothub_client_sample_upload_to_blob_mb
Scanning dependencies of target serializer
[ 81%] Building C object serializer/CMakeFiles/serializer.dir/src/agenttypesystem.c.o
[ 81%] Building C object serializer/CMakeFiles/serializer.dir/src/codefirst.c.o
[ 82%] Building C object serializer/CMakeFiles/serializer.dir/src/commanddecoder.c.o
[ 82%] Building C object serializer/CMakeFiles/serializer.dir/src/datamarshaller.c.o
[ 83%] Building C object serializer/CMakeFiles/serializer.dir/src/datapublisher.c.o
[ 83%] Building C object serializer/CMakeFiles/serializer.dir/src/dataserializer.c.o
[ 84%] Building C object serializer/CMakeFiles/serializer.dir/src/iotdevice.c.o
[ 84%] Building C object serializer/CMakeFiles/serializer.dir/src/jsondecoder.c.o
[ 85%] Building C object serializer/CMakeFiles/serializer.dir/src/jsonencoder.c.o
[ 85%] Building C object serializer/CMakeFiles/serializer.dir/src/multitree.c.o
[ 86%] Building C object serializer/CMakeFiles/serializer.dir/src/schema.c.o
[ 86%] Building C object serializer/CMakeFiles/serializer.dir/src/schemalib.c.o
[ 87%] Building C object serializer/CMakeFiles/serializer.dir/src/schemaserializer.c.o
[ 87%] Building C object serializer/CMakeFiles/serializer.dir/src/methodreturn.c.o
Linking C static library libserializer.a
[ 87%] Built target serializer
Scanning dependencies of target iothub_client_sample_mqtt_dm
[ 88%] Building C object iothub_client/samples/iothub_client_sample_mqtt_dm/CMakeFiles/iothub_client_sample_mqtt_dm.dir/iothub_client_sample_mqtt_dm.c.o
[ 88%] Building C object iothub_client/samples/iothub_client_sample_mqtt_dm/CMakeFiles/iothub_client_sample_mqtt_dm.dir/pi_device/pi.c.o
Linking C executable iothub_client_sample_mqtt_dm
[ 88%] Built target iothub_client_sample_mqtt_dm
Scanning dependencies of target iothub_client_sample_amqp_shared_methods
[ 89%] Building C object iothub_client/samples/iothub_client_sample_amqp_shared_methods/CMakeFiles/iothub_client_sample_amqp_shared_methods.dir/iothub_client_sample_amqp_shared_methods.c.o
[ 89%] Building C object iothub_client/samples/iothub_client_sample_amqp_shared_methods/CMakeFiles/iothub_client_sample_amqp_shared_methods.dir/__/__/__/certs/certs.c.o
Linking C executable iothub_client_sample_amqp_shared_methods
[ 89%] Built target iothub_client_sample_amqp_shared_methods
Scanning dependencies of target iothub_ll_client_shared_sample
[ 89%] Building C object iothub_client/samples/iothub_ll_client_shared_sample/CMakeFiles/iothub_ll_client_shared_sample.dir/iothub_ll_client_shared_sample.c.o
[ 90%] Building C object iothub_client/samples/iothub_ll_client_shared_sample/CMakeFiles/iothub_ll_client_shared_sample.dir/__/__/__/certs/certs.c.o
Linking C executable iothub_ll_client_shared_sample
[ 90%] Built target iothub_ll_client_shared_sample
Scanning dependencies of target iothub_client_device_twin_and_methods_sample
[ 91%] Building C object iothub_client/samples/iothub_client_device_twin_and_methods_sample/CMakeFiles/iothub_client_device_twin_and_methods_sample.dir/iothub_client_device_twin_and_methods_sample.c.o
[ 92%] Building C object iothub_client/samples/iothub_client_device_twin_and_methods_sample/CMakeFiles/iothub_client_device_twin_and_methods_sample.dir/__/__/__/certs/certs.c.o
Linking C executable iothub_client_device_twin_and_methods_sample
[ 92%] Built target iothub_client_device_twin_and_methods_sample
Scanning dependencies of target remote_monitoring
[ 93%] Building C object serializer/samples/remote_monitoring/CMakeFiles/remote_monitoring.dir/remote_monitoring.c.o
[ 93%] Building C object serializer/samples/remote_monitoring/CMakeFiles/remote_monitoring.dir/__/__/__/certs/certs.c.o
Linking C executable remote_monitoring
[ 93%] Built target remote_monitoring
Scanning dependencies of target simplesample_amqp
[ 94%] Building C object serializer/samples/simplesample_amqp/CMakeFiles/simplesample_amqp.dir/simplesample_amqp.c.o
[ 94%] Building C object serializer/samples/simplesample_amqp/CMakeFiles/simplesample_amqp.dir/linux/main.c.o
[ 95%] Building C object serializer/samples/simplesample_amqp/CMakeFiles/simplesample_amqp.dir/__/__/__/certs/certs.c.o
Linking C executable simplesample_amqp
[ 95%] Built target simplesample_amqp
Scanning dependencies of target simplesample_http
[ 95%] Building C object serializer/samples/simplesample_http/CMakeFiles/simplesample_http.dir/simplesample_http.c.o
[ 96%] Building C object serializer/samples/simplesample_http/CMakeFiles/simplesample_http.dir/linux/main.c.o
[ 96%] Building C object serializer/samples/simplesample_http/CMakeFiles/simplesample_http.dir/__/__/__/certs/certs.c.o
Linking C executable simplesample_http
[ 96%] Built target simplesample_http
Scanning dependencies of target temp_sensor_anomaly
[ 96%] Building C object serializer/samples/temp_sensor_anomaly/CMakeFiles/temp_sensor_anomaly.dir/windows/main.c.o
Linking C executable temp_sensor_anomaly
[ 96%] Built target temp_sensor_anomaly
Scanning dependencies of target simplesample_mqtt
[ 97%] Building C object serializer/samples/simplesample_mqtt/CMakeFiles/simplesample_mqtt.dir/simplesample_mqtt.c.o
[ 97%] Building C object serializer/samples/simplesample_mqtt/CMakeFiles/simplesample_mqtt.dir/linux/main.c.o
[ 98%] Building C object serializer/samples/simplesample_mqtt/CMakeFiles/simplesample_mqtt.dir/__/__/__/certs/certs.c.o
Linking C executable simplesample_mqtt
[ 98%] Built target simplesample_mqtt
Scanning dependencies of target devicemethod_simplesample
[ 98%] Building C object serializer/samples/devicemethod_simplesample/CMakeFiles/devicemethod_simplesample.dir/devicemethod_simplesample.c.o
[ 99%] Building C object serializer/samples/devicemethod_simplesample/CMakeFiles/devicemethod_simplesample.dir/linux/main.c.o
[ 99%] Building C object serializer/samples/devicemethod_simplesample/CMakeFiles/devicemethod_simplesample.dir/__/__/__/certs/certs.c.o
Linking C executable devicemethod_simplesample
[ 99%] Built target devicemethod_simplesample
Scanning dependencies of target devicetwin_simplesample
[100%] Building C object serializer/samples/devicetwin_simplesample/CMakeFiles/devicetwin_simplesample.dir/devicetwin_simplesample.c.o
Linking C executable devicetwin_simplesample
[100%] Built target devicetwin_simplesample
ewertons@debian820:~/azure-iot-sdk-c/cmake$
pboettch commented 6 years ago

As written in my initial issue description, I'm using 

$ gcc --version
gcc (Debian 8.2.0-4) 8.2.0
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

on Debian testing.

I'm using a1d22a998 of the SDK.

I'm getting:

[122/155] Building C object serializer/CMakeFiles/serializer_dll.dir/src/commanddecoder.c.o
FAILED: serializer/CMakeFiles/serializer_dll.dir/src/commanddecoder.c.o 
/usr/bin/cc -DARCHITECTURE_x86_64=1 -Dserializer_dll_EXPORTS -I/home/pboettch/devel/ett/ett-router/external/azure/azure-iot-sdk-c/c-utility/inc -I/home/pboettch/devel/ett/ett-router/external/azure/azure-iot-sdk-c/c-utility/pal/linux -I/home/pboettch/devel/ett/ett-router/external/azure/azure-iot-sdk-c/serializer/../deps/parson -I/home/pboettch/devel/ett/ett-router/external/azure/azure-iot-sdk-c/serializer/inc -I/home/pboettch/devel/ett/ett-router/external/azure/azure-iot-sdk-c/deps/uhttp/deps/c-utility/inc -fPIC  -Werror -O2 -g -DNDEBUG -fPIC   -std=gnu99 -MD -MT serializer/CMakeFiles/serializer_dll.dir/src/commanddecoder.c.o -MF serializer/CMakeFiles/serializer_dll.dir/src/commanddecoder.c.o.d -o serializer/CMakeFiles/serializer_dll.dir/src/commanddecoder.c.o   -c /home/pboettch/devel/ett/ett-router/external/azure/azure-iot-sdk-c/serializer/src/commanddecoder.c
In function ‘DecodeAndExecuteModelAction.isra.0’,
    inlined from ‘ScanActionPathAndExecuteAction’ at /home/pboettch/devel/ett/ett-router/external/azure/azure-iot-sdk-c/serializer/src/commanddecoder.c:441:26,
    inlined from ‘DecodeCommand’ at /home/pboettch/devel/ett/ett-router/external/azure/azure-iot-sdk-c/serializer/src/commanddecoder.c:607:22,
    inlined from ‘CommandDecoder_ExecuteCommand’ at /home/pboettch/devel/ett/ett-router/external/azure/azure-iot-sdk-c/serializer/src/commanddecoder.c:679:26:
/home/pboettch/devel/ett/ett-router/external/azure/azure-iot-sdk-c/serializer/src/commanddecoder.c:194:13: error: ‘strncpy’ specified bound depends on the length of the source argument [-Werror=stringop-overflow=]
         if (strncpy(tempStr, actionName, strLength - 1) == NULL)
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/pboettch/devel/ett/ett-router/external/azure/azure-iot-sdk-c/serializer/src/commanddecoder.c: In function ‘CommandDecoder_ExecuteCommand’:
/home/pboettch/devel/ett/ett-router/external/azure/azure-iot-sdk-c/serializer/src/commanddecoder.c:176:24: note: length computed here
     size_t strLength = strlen(actionName);
                        ^~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

You are using GCC 4.9 and you don't have this warning, because it was introduced in GCC 8.

pboettch commented 6 years ago

I saw that @jebrando made a commit similar to mine (maybe better, which is good) without considering my PR (not mentioning in its commit-message that it actually fixes this PR and the related issue).

What I find strange is that you are asking questions here to clarify and all and someone else on your team "simply" commits? How are external and internal pull-requests/commits are evaluated before being merged? Is there are process?

pboettch commented 6 years ago

I have to correct myself, there is effectively @jebrando's commit 5c75ce9a2ae298eb02be83d0c1a30d364fd92726 but this one does not fix the errors this PR fixes. I take back everything I said. ;-), well, part of it.

ewertons commented 6 years ago

Hi @pboettch , How are external and internal pull-requests/commits are evaluated before being merged?

Both internal and external pull requests are reviewed the same way by our team. All code goes through a careful review and requires sign-off from the team before being able to be checked in.

Is there are process?

After the code is approved by the team, it is submited to our automated CI build system, which will compile the SDK on all supported platforms, run unit and e2e tests, and only if all passes the code gets merged into master.

pboettch commented 6 years ago

Thanks for this explanation. Really helpful and creates confidence.