addresses supporting byte[] in direct methods and making TwinProperties able to be directly converted to json

[patilsnr]

addresses supporting byte[] in direct methods and making TwinProperties able to be directly converted to json

API surface diff:

namespace Microsoft.Azure.Devices.Client {
    public class DirectMethodRequest {
+       public byte[] GetPayload()
-               public byte[] GetPayloadAsBytes()
    }

       public class DirectMethodResponse {
+             public byte[] Payload { get; set; }
-             public object Payload { get; set; }
+             public object PayloadAsObject { get; set; }
       }

       public class EdgeModuleDirectMethodRequest {
+             internal byte[] Payload { get; set; }
-             internal object Payload { get; set; }
+             internal object PayloadAsObject { get; set; }              
       }
}

namespace Microsoft.Azure.Devices {
      public class DirectMethodClientResponse {
+           internal byte[] PayloadAsBytes { get; set; }
      }

      public class DirectMethodServiceRequest {
+          public byte[] Payload { get; set; }     
-           public object Payload { get; set; }
+          public object PayloadAsObject { get; set; }   
    }
}

[patilsnr]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 1 pipeline(s).

[patilsnr]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 1 pipeline(s).

[patilsnr]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 1 pipeline(s).

[patilsnr]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 1 pipeline(s).

[rido-min]

@patilsnr can you paste the Json returned by twin.GetSerializedJson? I'd like to check the reported and desired versions are properly formatted.

[patilsnr]

@patilsnr can you paste the Json returned by twin.GetSerializedJson? I'd like to check the reported and desired versions are properly formatted.

These are logs from the ThermostatSample that calls the method in question. I'm not sure what it should look like -- what do you think of this?

[rido-min]

I don't see the reported/desired versions

[patilsnr]

I don't see the reported/desired versions

How about this?

[rido-min]

Can you paste the text (json) we get from GetTwinAsyc ? we need the $version for reported and desired.

[patilsnr]

Can you paste the text (json) we get from GetTwinAsyc ? we need the $version for reported and desired.

Sure:

In this case, a brand new device will return the string expected when we call GetTwinPropertiesAsync (which calls GetTwinAsync internally. Debugging this test shows this for the variable twin that we get back:

Let me know if this is what you're looking for, this should hopefully show that both reported and desired properties are returning the correct version numbers as well as serializing properly

[rido-min]

this should be the same as V1 Twin.ToJson()

{
  "reported" : {
      "$version" : 1
  },
  "desired" : {
     "$version" : 1
  }
}

[patilsnr]

this should be the same as V1 Twin.ToJson()

{
  "reported" : {
      "$version" : 1
  },
  "desired" : {
     "$version" : 1
  }
}

Okay, with the exception of the key names being different (reported vs reportedProperties) they seem to be the same

[patilsnr]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 1 pipeline(s).

[patilsnr]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 1 pipeline(s).

[patilsnr]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 1 pipeline(s).

[patilsnr]

/azp run

[azure-pipelines[bot]]

No commit pushedDate could be found for PR 3340 in repo Azure/azure-iot-sdk-csharp

[patilsnr]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 1 pipeline(s).

[patilsnr]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 1 pipeline(s).

[patilsnr]

/azp run

[azure-pipelines[bot]]

No commit pushedDate could be found for PR 3340 in repo Azure/azure-iot-sdk-csharp

[patilsnr]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 1 pipeline(s).

[patilsnr]

/azp run

[azure-pipelines[bot]]

No commit pushedDate could be found for PR 3340 in repo Azure/azure-iot-sdk-csharp

[patilsnr]

/azp run

[azure-pipelines[bot]]

No commit pushedDate could be found for PR 3340 in repo Azure/azure-iot-sdk-csharp

[patilsnr]

/azp run

[azure-pipelines[bot]]

No commit pushedDate could be found for PR 3340 in repo Azure/azure-iot-sdk-csharp

[patilsnr]

/azp run

[azure-pipelines[bot]]

No commit pushedDate could be found for PR 3340 in repo Azure/azure-iot-sdk-csharp

[patilsnr]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 1 pipeline(s).

[patilsnr]

/azp run

[azure-pipelines[bot]]

No commit pushedDate could be found for PR 3340 in repo Azure/azure-iot-sdk-csharp

[patilsnr]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 1 pipeline(s).