Azure / azure-iot-sdk-node

A Node.js SDK for connecting devices to Microsoft Azure IoT services
https://docs.microsoft.com/en-us/azure/iot-hub/
Other
261 stars 227 forks source link

Add documentation button to pnp sample #1010

Closed JimacoMS4 closed 3 years ago

JimacoMS4 commented 3 years ago

Checklist

Reference/Link to the issue solved with this PR (if any)

Description of the problem

Description of the solution

Just adding a documentation button to the PNP sample that points to https://docs.microsoft.com/en-us/azure/iot-develop/ . Part of documentation effort.

JimacoMS4 commented 3 years ago

@timlt Please check out this PR before I send email to Eric. I want to make sure we're on the same page with the following:

Thanks,

Jimaco

timlt commented 3 years ago

Looks good to go!

ericmitt commented 3 years ago

Good for me as well. Thanks

JimacoMS4 commented 3 years ago

sign-off

JimacoMS4 commented 3 years ago

@ericmitt I'm not sure what else I need to do here to get this merged (Note I just closed and re-opened the request, so some checks might be in-progress). It's been sitting for several days.

JimacoMS4 commented 3 years ago

@pierreca @BertKleewein @anthonyvercolano can you please merge or let me know what else needs to be done? I'm not sure what to do to get the tests to complete, but the PR just adds some images for doc support and a button that points back to docs to one of the samples.

YoDaMa commented 3 years ago

@JimacoMS4 thanks for your patience. we're gonna get this merged in now.

YoDaMa commented 3 years ago

/azp run

azure-pipelines[bot] commented 3 years ago
Azure Pipelines successfully started running 2 pipeline(s).