fix: handle dropped connection failures

Azure / azure-iot-sdk-node

A Node.js SDK for connecting devices to Microsoft Azure IoT services

https://docs.microsoft.com/en-us/azure/iot-hub/

Other

261 stars 227 forks source link

fix: handle dropped connection failures #1036

Closed BertKleewein closed 3 years ago

YoDaMa commented 3 years ago

So the gist of this draft PR seems to be the code in two places:

there should be a context.error set from RHEA when the link_error and link_close events are fired. That is not currently the case. this is a bug in RHEA.
ServiceUnavailableError and NotConnectedError's should not be packaged inside another Error object.

In both cases these are bugs in our handling of RHEA errors for dropped connections, and we want to just expose those errors to the user, since there doesn't seem to be any other logic being altered here.

Am I missing something?

BertKleewein commented 3 years ago

Also:

link detach errors were being dropped and instead generic Error objects were being returned. Changes made to amqp_cbs.ts to pass the errors up, and sender_link detached._on_enter changed to return ServiceUnavailableError as a fallback error for detached links (was Error, which is not "retryable")

In reply to: 927946348

YoDaMa commented 3 years ago

when it's no longer a draft PR let me know.