search

Azure / azure-iot-sdk-node

A Node.js SDK for connecting devices to Microsoft Azure IoT services
https://docs.microsoft.com/en-us/azure/iot-hub/
Other
262 stars 227 forks source link

test(stresstests): initial stress D2C stress tests without faults #1071

Closed vishnureddy17 closed 2 years ago

vishnureddy17 commented 2 years ago

Apologies for the large PR. Should have broken this up into multiple reviews in hindsight.

These tests are flaky, so either the SDK needs some work or the tests need some tweaking.

BertKleewein commented 2 years ago 
  "": {

If you do lerna bootstrap --hoist, the delta isn't nearly this big. Regardless, the way we use this file seems silly -- our updating is ad-hoc and we don't actually use it for it's indented purpose. What do you think we should do about these files? What is the industry standards at this point?

Refers to: package-lock.json:6 in 291314d. [](commit_id = 291314dd2ef971a26ca562a1cb75b65ca869df32, deletion_comment = False)

vishnureddy17 commented 2 years ago 
  "": {

If you do lerna bootstrap --hoist, the delta isn't nearly this big. Regardless, the way we use this file seems silly -- our updating is ad-hoc and we don't actually use it for it's indented purpose. What do you think we should do about these files? What is the industry standards at this point?

Refers to: package-lock.json:6 in 291314d. [](commit_id = 291314d, deletion_comment = False)

@BertKleewein Not really sure what the standard is TBH, but I've just been committing the package-lock.jsons any time I change a dependency and omit them otherwise.