Azure / azure-iot-sdk-node

A Node.js SDK for connecting devices to Microsoft Azure IoT services
https://docs.microsoft.com/en-us/azure/iot-hub/
Other
262 stars 227 forks source link

fix typo in TemperatureController telemetry #1081

Closed rido-min closed 2 years ago

rido-min commented 2 years ago

workingset->workingSet

danhellem commented 2 years ago

@BertKleewein and @vishnureddy17 this is a PR to check against some tests. Per @rido-min

IIRC we were asking all SDK samples to run the certification tests , which should have detect this issue.

anthonyvercolano commented 2 years ago

/azp run

azure-pipelines[bot] commented 2 years ago
Azure Pipelines successfully started running 2 pipeline(s).
YoDaMa commented 2 years ago

/azp run

azure-pipelines[bot] commented 2 years ago
Azure Pipelines successfully started running 2 pipeline(s).
danhellem commented 2 years ago

@rido-min what do you want us to do with this?

rido-min commented 2 years ago

merge it? not sure why the pipeline fails since the change is fairly simple.

BertKleewein commented 2 years ago

The gates have been unreliable. I would be OK bypassing the gate for this change.

From: Rido @.> Sent: Friday, December 17, 2021 10:40 AM To: Azure/azure-iot-sdk-node @.> Cc: Bert Kleewein @.>; Mention @.> Subject: Re: [Azure/azure-iot-sdk-node] fix typo in TemperatureController telemetry (PR #1081)

merge it? not sure why the pipeline fails since the change is fairly simple.

- Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-iot-sdk-node%2Fpull%2F1081%23issuecomment-996938387&data=04%7C01%7Cbertk%40microsoft.com%7C30375538797c46b107bd08d9c18ca281%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637753632045347046%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=ZUoJRLX3kNMLQXTzc7R%2BiQx5%2BnANdl%2FsDD0xHhfGnCI%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAB5IEQRG6SHKZQJQNYLXUA3URN7YDANCNFSM5JHZJUUA&data=04%7C01%7Cbertk%40microsoft.com%7C30375538797c46b107bd08d9c18ca281%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637753632045347046%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=LeE3tXgfMmoOR3mKDLgktby9%2B7a%2BYvBW%2FSEYh3zr6FI%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7Cbertk%40microsoft.com%7C30375538797c46b107bd08d9c18ca281%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637753632045397044%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=JvSrhlr7EqN9GgDyPIQNhXa7z%2FLB94qi3pZYDNXpw6E%3D&reserved=0 or Androidhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7Cbertk%40microsoft.com%7C30375538797c46b107bd08d9c18ca281%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637753632045397044%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Jk5qVDyuW2aL1p5wKCvAdkDUxmjMEuzUA78G5LL4sqE%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.**@.>>

danhellem commented 2 years ago

/azp run

azure-pipelines[bot] commented 2 years ago
Azure Pipelines successfully started running 2 pipeline(s).
danhellem commented 2 years ago

/azp run

azure-pipelines[bot] commented 2 years ago
Azure Pipelines successfully started running 2 pipeline(s).
danhellem commented 2 years ago

Minor typo fix but the build keeps failing. I am going to just use my admin privileges to merge.