Azure / azure-iot-sdk-node

A Node.js SDK for connecting devices to Microsoft Azure IoT services

https://docs.microsoft.com/en-us/azure/iot-hub/

Other

261 stars 227 forks source link

Updated file upload sample to reflect current SDK changes. #834

Closed solidprinciples closed 4 years ago

solidprinciples commented 4 years ago

Checklist

[x] I have read the [contribution guidelines] (https://github.com/Azure/azure-iot-sdk-node/blob/master/.github/CONTRIBUTING.md).
[ ] I added or modified the existing tests to cover the change (we do not allow our test coverage to go down).
- There are no tests for covering samples, so this is not applicable.
If this is a modification that impacts the behavior of a public API
- [ ] I edited the corresponding document in the devdoc folder and added or modified requirements.

Reference/Link to the issue solved with this PR (if any)

No current issue was being tracked - the current SDK does not contain StorageURL, etc.

Description of the problem

Upload file sample does not work with the current-most SDKs.

Description of the solution

Updated the upload file sample code to reflect current most SDK changes.

YoDaMa commented 4 years ago

/azp run all

azure-pipelines[bot] commented 4 years ago

No pipelines are associated with this pull request.

YoDaMa commented 4 years ago

cheers for the PR @solidprinciples

anthonyvercolano commented 4 years ago

/azp run

azure-pipelines[bot] commented 4 years ago

Azure Pipelines successfully started running 2 pipeline(s).

solidprinciples commented 4 years ago

/azp run

azure-pipelines[bot] commented 4 years ago

Commenter does not have sufficient privileges for PR 834 in repo Azure/azure-iot-sdk-node

anthonyvercolano commented 4 years ago

/azp run all

azure-pipelines[bot] commented 4 years ago

No pipelines are associated with this pull request.

anthonyvercolano commented 4 years ago

/azp run

azure-pipelines[bot] commented 4 years ago

Azure Pipelines successfully started running 2 pipeline(s).

anthonyvercolano commented 4 years ago

@solidprinciples I'm going to let @YoDaMa be the judge on this PR, but, would you be able to fix the linting error?

> iot-device-samples@0.0.1 lint /home/vsts/work/1/s/device/samples
> jshint --show-non-errors .

upload_to_blob_advanced.js: line 87, col 21, Missing semicolon.

And push?

anthonyvercolano commented 4 years ago

/azp run

azure-pipelines[bot] commented 4 years ago

Azure Pipelines successfully started running 2 pipeline(s).

YoDaMa commented 4 years ago

/azp run

azure-pipelines[bot] commented 4 years ago

Azure Pipelines successfully started running 2 pipeline(s).

YoDaMa commented 4 years ago

/azp run

azure-pipelines[bot] commented 4 years ago

Azure Pipelines successfully started running 2 pipeline(s).

YoDaMa commented 4 years ago

/azp run

azure-pipelines[bot] commented 4 years ago

Azure Pipelines successfully started running 2 pipeline(s).

YoDaMa commented 4 years ago

/azp run node-canary

azure-pipelines[bot] commented 4 years ago

Azure Pipelines successfully started running 1 pipeline(s).

YoDaMa commented 4 years ago

/azp run node-canary

azure-pipelines[bot] commented 4 years ago

Azure Pipelines successfully started running 1 pipeline(s).