Azure / azure-kusto-dotnet

Azure Data Explorer (Kusto) SDK for .NET
MIT License
8 stars 5 forks source link

Inconsistency in ICslQueryProvider interface #15

Open fgheysels opened 1 year ago

fgheysels commented 1 year ago

The ICslQueryProvider interface declares a number of methods.
Among others, it declares the methods ExecuteQuery and ExecuteQueryAsync.

The ExecuteQuery method has an overload method which allows you to call the method without passing in a databaseName argument. The async variant (ExecuteQueryAsync) does not provide such an overload. However, it seems possible to call the method while passing in null or an empty string for the databaseName parameter.

I think it would be good to include an overload for the ExecuteQueryAsync method which takes just the query and client-request properties arguments:

Task<IDataReader> ExecuteQueryAsync (string query, ClientRequestProperties properties);

I'm using Microsoft.Azure.Kusto.Data version 11.2.1

slavikn84 commented 1 year ago

Thanks for reporting. We'll align the API per your request, and will release a new SDK version in a few weeks. I'll update here when we do.