search

Azure / azure-kusto-java

Microsoft Azure Kusto Library for Java
MIT License
38 stars 43 forks source link

Removes Apache HTTP URIBuilder #397

Closed georgebanasios closed 2 weeks ago

georgebanasios commented 2 weeks ago

Added

Changed

Removed Apache http URIBuilder.

Based on @yogilad 's comment on #396, all IPv6 addresses must now be enclosed in brackets in URLs. When retrieving the ingestion endpoint (IngestClientBase class), there is a call to InetAddressUtils.isIPv6Address() from Apache Http. This method performs regex matching and expects an IPv6 address without the brackets. That’s why I added the bracket-stripping logic, although it could be avoided by calling InetAddress.getByName(), which returns either an instance of IPv4 or IPv6 Address type.

Notes

The last three remaining occurrences of Apache http client and http core dependencies are:

  1. The method call I mentioned above in the IngestClientBase class.
  2. The stream wrapper in the streamingQuery method. I'm still trying to determine if the present stream wrappers there, are still needed after the move to Azure core http client.
  3. The unchecked ParseException.
georgebanasios commented 2 weeks ago

@microsoft-github-policy-service agree