search

Azure / azure-kusto-node

JS SDK for the Kusto service
MIT License
53 stars 39 forks source link

Parameters set in the clientRequestProperties are not sanitized to "dynamic" when needed #132

Open johnib opened 3 years ago

johnib commented 3 years ago

Hey,

Could not find the place where the parameters are converted to their kusto types, as described here.

For example, if I specify a date parameter:

clientRequestProperties.setParameter('startTime', new Date().toISOString());

Then something in your package will wrap the value with datetime(<value>). However, if I provide an array of values:

clientRequestProperties.setParameter('ids', [1,2,3]);

The package will not sanitize it to dynamic(<value>).

Tried looking for the actual code doing this sanitization, however I couldn't find it.

https://github.com/Azure/azure-kusto-node/blob/6f774914049f076a8d6cfbe0a8231b5c962e8ba8/azure-kusto-data/source/clientRequestProperties.ts#L64-L80

yihezkel commented 3 years ago

Hi @johnib ,

We will add this to our backlog.

As a workaround, please explicitly add the dynamic wrapper as needed.

CC @yogilad