search

Azure / azure-kusto-node

JS SDK for the Kusto service
MIT License
53 stars 39 forks source link

Move to new "nodenext" module type #318

Closed AsafMah closed 2 months ago

AsafMah commented 2 months ago

We need to move to the new exports for the web people.

For this, we need to put "exports": {...} in package.json files.

Currently, our moduleResolution is set to "node", which does not support this.

The ts docs: https://www.typescriptlang.org/docs/handbook/modules/guides/choosing-compiler-options.html#im-writing-a-library

Recommend using "NodeNext" for the most compatibility.

HOWEVER, this means that every relative import needs a .js in the end.

So this PR does that.

github-actions[bot] commented 2 months ago

Unit Test Results

    1 files  ±0    17 suites  +1   8m 26s :stopwatch: + 1m 37s 275 tests ±0  267 :heavy_check_mark: ±0  8 :zzz: ±0  0 :x: ±0  281 runs  ±0  273 :heavy_check_mark: ±0  8 :zzz: ±0  0 :x: ±0 

Results for commit 6e58658a. ± Comparison against base commit 8fc8270c.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.37%. Comparing base (eba9daf) to head (ad482f7). Report is 18 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #318 +/- ## ========================================== - Coverage 80.40% 71.37% -9.04% ========================================== Files 41 38 -3 Lines 2159 1792 -367 Branches 487 459 -28 ========================================== - Hits 1736 1279 -457 - Misses 409 485 +76 - Partials 14 28 +14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.