search

Azure / azure-libraries-for-java

Azure Management Libraries for Java
https://docs.microsoft.com/en-us/java/azure/
MIT License
94 stars 98 forks source link

Support user assigned identitites for AKS clusters #1296

Closed dennis-benzinger-hybris closed 3 years ago

dennis-benzinger-hybris commented 3 years ago

The library should support creating AKS cluster with user assigned identities.

The relevant REST documentation is on: https://docs.microsoft.com/en-us/rest/api/aks/managedclusters/createorupdate#managedclusteridentity

weidongxu-microsoft commented 3 years ago

@ChenTanyi Please help take a look.

dennis-benzinger-hybris commented 3 years ago

Do you have an ETA for this or will this feature be supported only in the "new style" SDK ?

nickzhums commented 3 years ago

@dennis-benzinger-hybris we are evaluating this and will let you know asap

ChenTanyi commented 3 years ago

@dennis-benzinger-hybris we would try to update the AKS and add this property before next release at Nov 27.

dennis-benzinger-hybris commented 3 years ago

That's great news. Thanks!

ChenTanyi commented 3 years ago

@dennis-benzinger-hybris After API updated, is it ok for you to use inner to assign identities?

(Since currently the identity type doesn't support SystenAssigned, UserAssigned, I'm afraid it would be change later, which could cause some problem in current logic.)

dennis-benzinger-hybris commented 3 years ago

Yes, inner is ok for use. We already use it in a few other places.

ChenTanyi commented 3 years ago

@dennis-benzinger-hybris Thanks for confirm. It will be release at Nov 27.

After update, the identity will be in ManagedClusterInner, you can use azure.kubernetesClusters().inner().beginCreateOrUpdate(), or kubernetesCluster.inner().withIdentity() and then kubernetesCluster.update().apply()