search

Azure / azure-libraries-for-java

Azure Management Libraries for Java
https://docs.microsoft.com/en-us/java/azure/
MIT License
94 stars 98 forks source link

webapp support api/settings from Kudu #1315

Closed weidongxu-microsoft closed 3 years ago

weidongxu-microsoft commented 3 years ago

fix https://github.com/Azure/azure-libraries-for-java/issues/1314

weidongxu-microsoft commented 3 years ago

@Flanker32 for review.

I didn't get a good name for the API method. Currently call it getSiteAppSettings (or maybe getKuduAppSettings). Let me know if any better idea.

Flanker32 commented 3 years ago

@Flanker32 for review.

I didn't get a good name for the API method. Currently call it getSiteAppSettings (or maybe getKuduAppSettings). Let me know if any better idea.

@weidongxu-microsoft Thanks a lot for your efforts! I think getKuduAppSettings may be better but both are fine~

weidongxu-microsoft commented 3 years ago

We will still use getSiteAppSettings, since previously we did not expose any method with "Kudu" in name (logStream, or zipDeploy).