Azure / azure-media-migration

Azure Media Migration Tool
https://github.com/Azure/azure-media-migration
MIT License
10 stars 13 forks source link

shaka-packager v2.6.1 is really old? #249

Open schuettecarsten opened 1 month ago

schuettecarsten commented 1 month ago

This project uses shaka-packager v2.6.1 which seems to be outdated. Current version is v3.2.0, see https://github.com/shaka-project/shaka-packager/releases/tag/v3.2.0

Is an upgrade useful and possible and will it fix some issues with incompatible files?

pohhsu commented 1 month ago

Hi @schuettecarsten,

At the time of development of this tool, v2.6.1 was the only version available so that why we chose it.

Yes, the new packager should have fixes to some issues. There were two fixes that @duggaraju and @xieyubo contributed to the shaka packager codebase that weren't in the v.2.6.1 release, e.g.

Unfortunately, we don't have the resources currently to test the new build of shaka packager.

You are welcome to try the new build, you can modify the AMSMigrate.csproj to grab the new build

https://github.com/shaka-project/shaka-packager/releases/download/v2.6.1/packager-win-x64.exe https://github.com/shaka-project/shaka-packager/releases/download/v2.6.1/packager-linux-x64 https://github.com/shaka-project/shaka-packager/releases/download/v2.6.1/packager-osx-x64 we would be interested in learning your experiences with the new tool.
schuettecarsten commented 1 month ago

@pohhsu Thanks, I will update and let you know if it fixes some of my issues. First finding is that you need latest vc_redist.x64.exe installed (https://learn.microsoft.com/en-us/cpp/windows/latest-supported-vc-redist?view=msvc-170#latest-microsoft-visual-c-redistributable-version) to use the newer version.

pohhsu commented 1 month ago

@schuettecarsten , thanks!

Just a heads up, I don't think the new shaka packager version will help you with the issues you hit in issue:

https://github.com/Azure/azure-media-migration/issues/251

as those two errors are raised in Azure Migration Tool, prior to calling shaka packager. Sorry about that...

schuettecarsten commented 1 month ago

253