yshafner commented 2 months ago

Overview/Summary

Changed the index of a loop to access the RG name. Originally it was 4 and returning "microsoft.providers" but should be the RG name.

This PR fixes/adds/changes/removes

NA

[ x] Read the Contribution Guide and ensured this PR is compliant with the guide
[x ] Checked for duplicate Pull Requests
[x ] Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
[x ] Ensured my code/branch is up-to-date with the latest changes in the main branch
[x ] Ensured PR tests are passing
[ x] Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

JCoreMS commented 2 months ago

Great find on this @yshafner. This will resolve the permissions setting that was failing during deployment.

arjenhuitema commented 2 months ago

Great find on this @yshafner. This will resolve the permissions setting that was failing during deployment.

Hi @JCoreMS, are you referring to issue #288, does this PR solve that?

yshafner commented 2 months ago

@JCoreMS @arjenhuitema Can this be merged?