Azure / azure-monitor-baseline-alerts

Azure Monitor Baseline Alerts
MIT License
167 stars 243 forks source link

Update useCommonSchema to useCommonAlertSchema in `Deploy_ServiceHealth_ActionGroups` and `Deploy_Suppression_AlertProcessing_Rule` Policy Definitions #346

Closed haflidif closed 1 month ago

haflidif commented 2 months ago

Overview/Summary

This PR updates wrong variables for enabling use of Common Alert Schema for LogicApp, EmailRecievers and ARMRoleRecievers as in:

Update useCommonSchema to useCommonAlertSchema in Deploy_ServiceHealth_ActionGroups and Deploy_Suppression_AlertProcessing_Rule Policy Definitions

This PR fixes/adds/changes/removes

  1. fixes #345

Breaking Changes

  1. There should not be any breaking changes here, only a fuctional ARM Templates that are being deployed instead of non functioning arm templates when these services are being used for sending notifications alerts.

As part of this Pull Request I have

arjenhuitema commented 1 month ago

Hi @haflidif, thank you for the feedback and for submitting the PR; it's much appreciated.

@ymehdimsft, you have been assigned a story for this sprint to tackle this issue. Could you please review the changes in this PR and compare them with your story?

Dikkekip commented 1 month ago

Nice one @haflidif !