Add Xiaomi Installation

Azure / azure-notificationhubs-dotnet

.NET SDK for Azure Notification Hubs

MIT License

70 stars 123 forks source link

Add Xiaomi Installation #259

Open weihengSu2 opened 1 year ago

weihengSu2 commented 1 year ago

Things to consider before you submit the PR:

[x] Are tests passing locally?
[x] Are the files formatted correctly?
[x] Did you add unit tests?
[ ] Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Description

Add Xiaomi Installation classes

marstr commented 1 year ago

Have these changes been tested with the following method to see if a valid request is generated? Bonus points if it's actually worked against our backend. https://github.com/Azure/azure-notificationhubs-dotnet/blob/5f9e17a8ad2ae5c6a1b2269ab01565eb6228951d/src/Microsoft.Azure.NotificationHubs/NotificationHubClient.cs#L1092

weihengSu2 commented 1 year ago

Have these changes been tested with the following method to see if a valid request is generated? Bonus points if it's actually worked against our backend.

https://github.com/Azure/azure-notificationhubs-dotnet/blob/5f9e17a8ad2ae5c6a1b2269ab01565eb6228951d/src/Microsoft.Azure.NotificationHubs/NotificationHubClient.cs#L1092

Yes I will do the actual integration tests today including this one. And thanks very much for the review too! 🙂