Add xiaomi credential - Githubissues

Azure / azure-notificationhubs-dotnet

.NET SDK for Azure Notification Hubs

MIT License

70 stars 119 forks source link

Add xiaomi credential #262

Closed weihengSu2 closed 1 year ago

weihengSu2 commented 1 year ago

Things to consider before you submit the PR:

[x] Are tests passing locally?
[x] Are the files formatted correctly?
[ ] Did you add unit tests?
[ ] Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Description

The PR will add XiaomiCredentials to the Azure NotificationHub SDK.Net repo, which will be used as part of the auth header to send Xiaomi Notifications which are in another PR

jessHuh commented 1 year ago

I left some comments. Could we also add some tests? Thanks!

weihengSu2 commented 1 year ago

I left some comments. Could we also add some tests? Thanks!

We don't have unit tests for Credential classes like ApnsCredential or other Credentials. But I could try to add to a program.cs or add a new unit test class for Credential?

weihengSu2 commented 1 year ago

I have addressed the comments in https://github.com/Azure/azure-notificationhubs-dotnet/pull/264 cuz I combined 260/261/262 in that PR before