Feature/fcmv1 - Githubissues

rextor92 commented 6 months ago

Description

I have added the newly created SendFcmV1NativeNotificationAsync methods to the INotificationHubClient so that we can continue mocking a client in projects after updating.

Also added some FCMv1 tests with the new payload structure for notifications.

Related PRs or issues

Fixes #307 Relates to #110

Misc

[x] Upon running the tests without Notification Hub settings in appconfig.json (in RecordingMode.Playback), the newly added tests will fail as there are no files in MockData. I have ran the tests with my notification hub (RecordingMode.Recording) and can add the necessary files, but I am unsure whether you'd want to do it yourself against the sdk-sample-namespace ANH?
[ ] We are not just adding FCMv1 support here, GCM/FCM will be disabled on July 1st, 2024. I would like to add deprecated tags on the relevant methods - as in the Java implementation of the change. I am thinking of something like [Obsolete("SendFcmNativeNotificationAsync will be deprecated on July 1st, 2024. Please use SendFcmV1NativeNotificationAsync instead.")]
[x] We'll also have to bump the package version to 4.2.1

Things to consider before you submit the PR:

[x] Are tests passing locally?
[x] Are the files formatted correctly?
[x] Did you add unit tests?
[x] Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

rextor92 commented 6 months ago

@microsoft-github-policy-service agree

developer9969 commented 4 months ago

hi - would it possible to know when this will be merged?

rextor92 commented 4 months ago

It's been sitting with some open questions for a while. I can see @jessHuh is typically assigned to review some recent PRs.

developer9969 commented 4 months ago

ok - is it a case of lack of time for @jessHuh to have a look at this and move it forward?

developer9969 commented 3 months ago

Greatly appreciated if this could be reviewed

developer9969 commented 3 months ago

this is just a joke now - Common what is the problem not even the bliming courtesy to say something

lomagdal2 commented 3 months ago

@rextor92 looks good.

No need for you to upload your test files. Go ahead and add the deprecation tags. Yes, package will be bumped to 4.2.1.

After you push up your changes I will sign off on this PR.

gabsamples6 commented 1 month ago

Hi - why does it take sooooo long to merge this one and push a new nuget??? It would help to know @lomagdal2

TedMobile commented 1 month ago

Any chance of this pull request being merged? Many thanks

Azure / azure-notificationhubs-dotnet

Feature/fcmv1 #311

Description

Related PRs or issues

Misc