v0.5 - Refactoring Experience - Githubissues

Azure / azure-notificationhubs-java-backend

Azure Notification Hubs SDK for Java

https://docs.microsoft.com/en-us/azure/notification-hubs/

Apache License 2.0

35 stars 49 forks source link

v0.5 - Refactoring Experience #100

Closed mpodwysocki closed 3 years ago

mpodwysocki commented 3 years ago

Things to consider before you submit the PR:

[x] Are tests passing locally?
[x] Are the files formatted correctly?
[x] Did you add unit tests?
[x] Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Description

Adds the following features:

Created per PNS notification classes instead of the Notification class itself
- AdmNotification
- AppleNotification
- BaiduNotification
- FcmNotification
- MpnsNotification
- WindowsNotification
Added method to save an installation through the BaseInstallation

Misc stuff fixed:

Added JavaDoc to all public members
Rewrote equals and hashcode implementations based upon IntelliJ recommendations
Migrated SAS token creation to a single SasTokenProvider

Related PRs or issues

N/A

Misc

N/A