Updates PnsCredential to invoke the correct setters when credential property names are returned in camelCase instead of PascalCase. When the properties are camelCase, the SDK attempts to invoke setters with a different casing when parsing NotificationHubDescriptions, resulting in various functions (such as getNotificationHub()) crashing.
Also:
Marks camelCase variant of setgoogleApiKey as deprecated
Updates JUnit to 5 to use ParameterizedTests
Things to consider before you submit the PR:
[x] Are tests passing locally?
[x] Are the files formatted correctly?
[x] Did you add unit tests?
[x] Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?
Description
Updates
PnsCredential
to invoke the correct setters when credential property names are returned in camelCase instead of PascalCase. When the properties are camelCase, the SDK attempts to invoke setters with a different casing when parsingNotificationHubDescription
s, resulting in various functions (such asgetNotificationHub()
) crashing.Also:
camelCase
variant ofsetgoogleApiKey
as deprecatedThings to consider before you submit the PR:
Related PRs or issues
Reported in Issue #169