Azure / azure-notificationhubs-samples

Microsoft Azure Notification Hubs Samples
Apache License 2.0
162 stars 240 forks source link

Fixed android client notification with non-latin characters. #48

Closed wxwr closed 7 years ago

wxwr commented 7 years ago

Android client app fails to send notification with non-latin chracters. Message bytes won't be calculated accordingly, you can use this arabic word to repro ( عربى ).

android client exception

msftclas commented 7 years ago

@wagsousa, Thanks for your contribution. To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects. Thanks, Microsoft Pull Request Bot

wxwr commented 7 years ago

Just for reference: https://stackoverflow.com/questions/16270994/difference-between-string-length-and-string-getbytes-length

msftclas commented 7 years ago

@wagsousa, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

msftclas commented 7 years ago

@wagsousa, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot