Azure / azure-openai-benchmark

Azure OpenAI benchmarking tool
MIT License
130 stars 55 forks source link

Properly reflecting the count of "requests" #41

Open sushaanttb opened 9 months ago

sushaanttb commented 9 months ago

The value of "requests" field in the output log is determined by the variable total_requests_count which currently is getting updated on the "aggregate" function, which gets called after the HTTP response is received.

image

Due to this, the output log, doesn't depicts a true value of this metric. PFB log output for ref.

image

Ideally, shouldn't the value of total_requests_count be updated in record_new_request function itself?