search

Azure / azure-openapi-validator

Azure Open API Validator
MIT License
47 stars 46 forks source link

TagsAreNotAllowedForProxyResources flagging TrackedResources incorrectly #741

Open PriyankaHariharan opened 2 months ago

PriyankaHariharan commented 2 months ago

Describe the bug Swagger LintDiff is incorrectly flagging TrackedResources with the TagsAreNotAllowedForProxyResources rule. These swaggers are auto generated using TypeSpecTrackedResource function. The reason this check is looking at these files is because there is no location property for this tracked resource, however this is generated via TypeSpec.

Link to tracked resource in TSP: image

Link to error being flagged incorrectly in our swagger for the same resource: image

To Reproduce Link to PR with this error: https://github.com/Azure/azure-rest-api-specs-pr/pull/19487/checks?check_run_id=29804223056 Related Teams discussion: https://teams.microsoft.com/l/message/19:0351f5f9404446e4b4fd4eaf2c27448d@thread.skype/1725583802723?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=3e17dcb0-4257-4a30-b843-77f47f1d4121&parentMessageId=1725583802723&teamName=Azure%20SDK&channelName=API%20Spec%20Review&createdTime=1725583802723

Expected behavior Check should not flag tracked resources with this rule.

Screenshots

image

Desktop (please complete the following information): N/A Linter Rule

Additional context Add any other context about the problem here.

SathishMSFT commented 2 months ago

I am also facing same issues with this PR https://github.com/Azure/azure-rest-api-specs-pr/pull/19198. The resource that is flagged is already tracked resource.

mikeharder commented 2 months ago

Another error:

https://github.com/Azure/azure-rest-api-specs/pull/28274/checks?check_run_id=29770175797

@tejaswiMinnu, @rkmanda: Given the number of specs hitting errors from this rule, are you sure the rule is correct? If so, what do these specs need to change to comply with the rule?