This pull request primarily focuses on the transition from using DisableErrorRecordsPersistence to EnableErrorRecordsPersistence in the ConfigKeysForCommon class and the ShouldRecordDebugMessages method. The changes are made to improve the code's readability and to make the feature opt-in rather than opt-out.
Key changes include:
src/Authentication.Abstractions/Models/ConfigKeysForCommon.cs: Removed the DisableErrorRecordsPersistence constant from the ConfigKeysForCommon class. The EnableErrorRecordsPersistence constant is now being used instead. This change is made to switch from an opt-out to an opt-in system for error record persistence.
src/Common/AzurePSCmdlet.cs: Modified the ShouldRecordDebugMessages method to use the EnableErrorRecordsPersistence constant instead of the DisableErrorRecordsPersistence constant. This change aligns with the modification in ConfigKeysForCommon and ensures consistency across the codebase.
This pull request primarily focuses on the transition from using
DisableErrorRecordsPersistencetoEnableErrorRecordsPersistencein theConfigKeysForCommonclass and theShouldRecordDebugMessagesmethod. The changes are made to improve the code's readability and to make the feature opt-in rather than opt-out.Key changes include:
src/Authentication.Abstractions/Models/ConfigKeysForCommon.cs: Removed theDisableErrorRecordsPersistenceconstant from theConfigKeysForCommonclass. TheEnableErrorRecordsPersistenceconstant is now being used instead. This change is made to switch from an opt-out to an opt-in system for error record persistence.src/Common/AzurePSCmdlet.cs: Modified theShouldRecordDebugMessagesmethod to use theEnableErrorRecordsPersistenceconstant instead of theDisableErrorRecordsPersistenceconstant. This change aligns with the modification inConfigKeysForCommonand ensures consistency across the codebase.