search

Azure / azure-powershell-common

Microsoft Azure PowerShell common components
Other
35 stars 56 forks source link

Add Interface to Send Auth Info to Telemetry #421

Open msJinLei opened 3 months ago

msJinLei commented 3 months ago
msJinLei commented 4 weeks ago

No change since last review

msJinLei commented 4 weeks ago

1 Cmdlet telemetry : N auth telemetry. Conclusion: data structure => array, but only 1 element. Todo: test if array is OK to be stored in kusto?

Cannot use array directly, the current solution is to expand the first (most important) authentication telemetry record and serialize the other parts into a json string

telemetry key naming convention. Conclusion: use dash. General conclusion: ?

Scope. Can we leverage MSAL telemetry? Todo: remove AuthorityUri. Consider adding correlation ID later. Consider enable telemetry of -Environment parameter. CorrelationId is added but not way to get id from MSAL, need MSAL team to support

leverage Beisi & Lei's design. Conclusion: not much.

Codegen => Todo: next sprint. Create task. Done, need more test

TokenCacheEnabled => nice to have. Consider risk & effort of testing. removed