YanaXu
commented
1 month ago PR itself looks good. If we do this, does it make the logic of setting sub id in AzureRMCmdlet.BeginProcessing duplicate, and can we remove that? Also, this will impact cmdlets that do not inherit AzureRMCmdlet . Please ensure we have tested that scneario. Thanks.
@isra-fel , according to your comment, I changed the update and test the below cmdlets. Their subscription ids and tenant ids are recorded correctly now.
- Get-AzAksCluster
- Get-AzConfig
- Get-AzDatabricksWorkspace
- Get-AzContainerApp
- Get-AzEnvironment
- Get-AzContext
- Get-AzAccessToken
- Get-AzSqlVM
- Connect-AzAccount
It's for
Content-AzAccount. When it's run, the subscription id and tenant id is not set in context. That's why they are empty in telemetry. This PR is going to set them before recording the telemetry.