search

Azure / azure-powershell

Microsoft Azure PowerShell
Other
4.21k stars 3.82k forks source link

migrate common assemblies in attestation module to Az.Accounts #11262

Open VeryEarly opened 4 years ago

VeryEarly commented 4 years ago

Description of the new feature

3 assemblies were introduced in Az.Attestation: https://github.com/Azure/azure-powershell/pull/11247

need to move these assemblies to azure-powershell-common and reference from there: 'Microsoft.IdentityModel.JsonWebTokens.dll', 'Microsoft.IdentityModel.Tokens.dll', 'Microsoft.IdentityModel.Logging.dll'

Proposed implementation details (optional)

dingmeng-xue commented 4 years ago

I'd like to revisit impact of this change. Please set up a conversation with @erich-wang and me.

erich-wang commented 4 years ago

Postpone the issue as it needs to update loading assembly logic from loading assemblies in advance to demand.

sopelt commented 1 year ago

FYI I came across this when having problems with dependency conflicts with Microsoft graph as discussed in https://github.com/microsoftgraph/msgraph-sdk-powershell/issues/1818 and https://github.com/Azure/azure-powershell/issues/20933

In short: Microsoft.IdentityModel.Tokens.dll is also shipped by Microsoft.Graph.Authentication but the differing versions collide.