search

Azure / azure-powershell

Microsoft Azure PowerShell
Other
4.18k stars 3.79k forks source link

AzureRm.Resources :: ARM Policy Commands should not expose -ApiVersion parameter #1360

Open pcgeek86 opened 8 years ago

pcgeek86 commented 8 years ago

The commands pertaining to Azure Resource Manager (ARM) Policy Definitions and Policy Assignments should not expose an -ApiVersion parameter. This should be abstracted, by the module, on behalf of the end user.

Cheers, Trevor Sullivan Microsoft MVP: PowerShell http://trevorsullivan.net http://twitter.com/pcgeek86

markcowl commented 8 years ago

@vivsriaus It's appropriate to have a -ApiVersion parameter for generic cmdlets addressed at specific RPs, but don't think we should have this for cmdlets aimed at ARM itself, or typed cmdlets. Also, it would be much more user-friendly if generic cmdlets that had this parameter would make the parameter optional and automatically query for a valid api version and use it if none is supplied.

ravbhatnagar commented 8 years ago

@ravbhatnagar Check if this is optional.

ravbhatnagar commented 8 years ago

We currently have this param exposed for other ARM cmdlets also. Will need to do a complete sweep to ensure consistency.

pcgeek86 commented 8 years ago

Thanks @ravbhatnagar!

maddieclayton commented 6 years ago

@ravbhatnagar @vivsriaus We should address this issue, can you take another look?