Azure / azure-powershell

Microsoft Azure PowerShell
Other
4.26k stars 3.87k forks source link

Update Set-AzStorageSyncServer to reset identity #26724

Open stefong99 opened 3 days ago

stefong99 commented 3 days ago

Description

Update the Set-AzStorageSyncServer command to reset the identity of the server when using MI.

Mandatory Checklist

azure-client-tools-bot-prd[bot] commented 3 days ago
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.
github-actions[bot] commented 3 days ago

‼️ DO NOT MERGE THIS PR ‼️ This PR was labeled "Do Not Merge" because it contains code change that cannot be merged. Please contact the reviewer for more information.

ankushbindlish2 commented 3 days ago

Please add unit test for this cmdlet

ankushbindlish2 commented 3 days ago

Use autorest.Powershell Doc : How to generate SDK with autorest.powershell to replace track 1 SDK | Azure CLI Tools Wiki

ankushbindlish2 commented 3 days ago

changing interface IStorageSyncResourceManager would require changing MockStorageSyncResourceManager

ankushbindlish2 commented 3 days ago

Support it being cloud cmdlet as well, not just hybrid

ankushbindlish2 commented 3 days ago

Do not allow customer to set the identity from false and application non-guid as same request.