Add Diagnostics and Warnings to Deployments WhatIf/Validate cmdlets

[tsmallig33]

Description

Add diagnostic messages and warnings to Resource Deployments WhatIf and Test cmdlets (e.g. TestDeploymentCmdletBaseand DeploymentWhatIfCmdlet)

Mandatory Checklist

• Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)

  • [X] General release
  • [ ] Public preview
  • [ ] Private preview
  • [ ] Engineering build
  • [ ] No need for a release

• [X] Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

• SHOULD update ChangeLog.md file(s) appropriately

  • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
  • For autorest-based development mode, include the changelog in the PR description.
  • Should not change ChangeLog.md if no new release is required, such as fixing test case only.

• SHOULD regenerate markdown help files if there is cmdlet API change. Instruction

• SHOULD have proper test coverage for changes in pull request.

• SHOULD NOT adjust version of module manually in pull request

[azure-client-tools-bot-prd[bot]]

️✔️Az.Accounts

>

>

️✔️Build

> >>

>>

️✔️PowerShell Core - Windows

>> >> >>

>>

>>

️✔️Windows PowerShell - Windows

>> >> >>

>

⚠️Az.Blueprint

>

>

️✔️Build

> >>

>>

️✔️PowerShell Core - Windows

>> >> >>

>>

>>

️✔️Windows PowerShell - Windows

>> >> >>

>

>

>

⚠️Test

> >>

>>

⚠️ - Linux

>> >>|Type|Title|Current Coverage|Description| >>|---|---|---|---| >>|⚠️|Test Coverage Less Than 50%|23.08 %|Test coverage for the module cannot be lower than 50%.| >> >>

>>

>>

⚠️ - MacOS

>> >>|Type|Title|Current Coverage|Description| >>|---|---|---|---| >>|⚠️|Test Coverage Less Than 50%|23.08%|Test coverage for the module cannot be lower than 50%.| >> >>

>>

>>

⚠️PowerShell Core - Windows

>> >>|Type|Title|Current Coverage|Description| >>|---|---|---|---| >>|⚠️|Test Coverage Less Than 50%|23.08%|Test coverage for the module cannot be lower than 50%.| >> >>

>>

>>

⚠️Windows PowerShell - Windows

>> >>|Type|Title|Current Coverage|Description| >>|---|---|---|---| >>|⚠️|Test Coverage Less Than 50%|23.08%|Test coverage for the module cannot be lower than 50%.| >> >>

>

️✔️Az.CosmosDB

>

>

️✔️Build

> >>

>>

️✔️PowerShell Core - Windows

>> >> >>

>>

>>

️✔️Windows PowerShell - Windows

>> >> >>

>

>

>

️✔️Test

> >>

>>

️✔️ - Linux

>> >> >>

>>

>>

️✔️ - MacOS

>> >> >>

>>

>>

️✔️PowerShell Core - Windows

>> >> >>

>>

>>

️✔️Windows PowerShell - Windows

>> >> >>

>

️✔️Az.KeyVault

>

>

️✔️Build

> >>

>>

️✔️PowerShell Core - Windows

>> >> >>

>>

>>

️✔️Windows PowerShell - Windows

>> >> >>

>

⚠️Az.MachineLearning

>

>

️✔️Build

> >>

>>

️✔️PowerShell Core - Windows

>> >> >>

>>

>>

️✔️Windows PowerShell - Windows

>> >> >>

>

>

>

⚠️Test

> >>

>>

⚠️ - Linux

>> >>|Type|Title|Current Coverage|Description| >>|---|---|---|---| >>|⚠️|Test Coverage Less Than 50%|0.00 %|Test coverage for the module cannot be lower than 50%.| >> >>

>>

>>

⚠️ - MacOS

>> >>|Type|Title|Current Coverage|Description| >>|---|---|---|---| >>|⚠️|Test Coverage Less Than 50%|0.00%|Test coverage for the module cannot be lower than 50%.| >> >>

>>

>>

⚠️PowerShell Core - Windows

>> >>|Type|Title|Current Coverage|Description| >>|---|---|---|---| >>|⚠️|Test Coverage Less Than 50%|0.00%|Test coverage for the module cannot be lower than 50%.| >> >>

>>

>>

⚠️Windows PowerShell - Windows

>> >>|Type|Title|Current Coverage|Description| >>|---|---|---|---| >>|⚠️|Test Coverage Less Than 50%|0.00%|Test coverage for the module cannot be lower than 50%.| >> >>

>

️✔️Az.ManagedServiceIdentity

>

>

️✔️Build

> >>

>>

️✔️PowerShell Core - Windows

>> >> >>

>>

>>

️✔️Windows PowerShell - Windows

>> >> >>

>

️✔️Az.Monitor

>

>

️✔️Build

> >>

>>

️✔️PowerShell Core - Windows

>> >> >>

>>

>>

️✔️Windows PowerShell - Windows

>> >> >>

>

️✔️Az.Network

>

>

️✔️Build

> >>

>>

️✔️PowerShell Core - Windows

>> >> >>

>>

>>

️✔️Windows PowerShell - Windows

>> >> >>

>

⚠️Az.Resources

>

>

️✔️Build

> >>

>>

️✔️PowerShell Core - Windows

>> >> >>

>>

>>

️✔️Windows PowerShell - Windows

>> >> >>

>

>

>

️✔️Breaking Change Check

> >>

>>

️✔️PowerShell Core - Windows

>> >> >>

>>

>>

️✔️Windows PowerShell - Windows

>> >> >>

>

>

>

⚠️Signature Check

> >>

>>

⚠️PowerShell Core - Windows

>> >>|Type|Cmdlet|Description|Remediation| >>|---|---|---|---| >>|⚠️|Get-AzADGroupOwner|Get-AzADGroupOwner Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute.|Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue| >>|⚠️|Get-AzADGroupOwner|Get-AzADGroupOwner changes the confirm impact. Please ensure that the change in ConfirmImpact is justified|Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.| >>|⚠️|Get-AzADServicePrincipalAppRoleAssignment|Get-AzADServicePrincipalAppRoleAssignment Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute.|Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue| >>|⚠️|Get-AzADServicePrincipalAppRoleAssignment|Get-AzADServicePrincipalAppRoleAssignment changes the confirm impact. Please ensure that the change in ConfirmImpact is justified|Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.| >>|⚠️|Get-AzDataBoundaryScope|Get-AzDataBoundaryScope Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute.|Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue| >>|⚠️|Get-AzDataBoundaryScope|Get-AzDataBoundaryScope changes the confirm impact. Please ensure that the change in ConfirmImpact is justified|Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.| >>|⚠️|Get-AzDataBoundaryTenant|Get-AzDataBoundaryTenant Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute.|Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue| >>|⚠️|Get-AzDataBoundaryTenant|Get-AzDataBoundaryTenant changes the confirm impact. Please ensure that the change in ConfirmImpact is justified|Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.| >>|⚠️|Get-AzPolicyAssignment|Get-AzPolicyAssignment Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute.|Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue| >>|⚠️|Get-AzPolicyAssignment|Get-AzPolicyAssignment changes the confirm impact. Please ensure that the change in ConfirmImpact is justified|Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.| >>|⚠️|Get-AzPolicyDefinition|Get-AzPolicyDefinition Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute.|Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue| >>|⚠️|Get-AzPolicyDefinition|Get-AzPolicyDefinition changes the confirm impact. Please ensure that the change in ConfirmImpact is justified|Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.| >>|⚠️|Get-AzPolicyExemption|Get-AzPolicyExemption Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute.|Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue| >>|⚠️|Get-AzPolicyExemption|Get-AzPolicyExemption changes the confirm impact. Please ensure that the change in ConfirmImpact is justified|Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.| >>|⚠️|Get-AzPolicySetDefinition|Get-AzPolicySetDefinition Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute.|Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue| >>|⚠️|Get-AzPolicySetDefinition|Get-AzPolicySetDefinition changes the confirm impact. Please ensure that the change in ConfirmImpact is justified|Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.| >> >>

>>

>>

⚠️Windows PowerShell - Windows

>> >>|Type|Cmdlet|Description|Remediation| >>|---|---|---|---| >>|⚠️|Get-AzADGroupOwner|Get-AzADGroupOwner Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute.|Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue| >>|⚠️|Get-AzADGroupOwner|Get-AzADGroupOwner changes the confirm impact. Please ensure that the change in ConfirmImpact is justified|Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.| >>|⚠️|Get-AzADServicePrincipalAppRoleAssignment|Get-AzADServicePrincipalAppRoleAssignment Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute.|Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue| >>|⚠️|Get-AzADServicePrincipalAppRoleAssignment|Get-AzADServicePrincipalAppRoleAssignment changes the confirm impact. Please ensure that the change in ConfirmImpact is justified|Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.| >>|⚠️|Get-AzDataBoundaryScope|Get-AzDataBoundaryScope Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute.|Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue| >>|⚠️|Get-AzDataBoundaryScope|Get-AzDataBoundaryScope changes the confirm impact. Please ensure that the change in ConfirmImpact is justified|Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.| >>|⚠️|Get-AzDataBoundaryTenant|Get-AzDataBoundaryTenant Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute.|Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue| >>|⚠️|Get-AzDataBoundaryTenant|Get-AzDataBoundaryTenant changes the confirm impact. Please ensure that the change in ConfirmImpact is justified|Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.| >>|⚠️|Get-AzPolicyAssignment|Get-AzPolicyAssignment Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute.|Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue| >>|⚠️|Get-AzPolicyAssignment|Get-AzPolicyAssignment changes the confirm impact. Please ensure that the change in ConfirmImpact is justified|Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.| >>|⚠️|Get-AzPolicyDefinition|Get-AzPolicyDefinition Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute.|Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue| >>|⚠️|Get-AzPolicyDefinition|Get-AzPolicyDefinition changes the confirm impact. Please ensure that the change in ConfirmImpact is justified|Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.| >>|⚠️|Get-AzPolicyExemption|Get-AzPolicyExemption Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute.|Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue| >>|⚠️|Get-AzPolicyExemption|Get-AzPolicyExemption changes the confirm impact. Please ensure that the change in ConfirmImpact is justified|Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.| >>|⚠️|Get-AzPolicySetDefinition|Get-AzPolicySetDefinition Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute.|Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue| >>|⚠️|Get-AzPolicySetDefinition|Get-AzPolicySetDefinition changes the confirm impact. Please ensure that the change in ConfirmImpact is justified|Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.| >> >>

>

>

>

️✔️Help File Existence Check

> >>

>>

️✔️PowerShell Core - Windows

>> >> >>

>>

>>

️✔️Windows PowerShell - Windows

>> >> >>

>

>

>

️✔️File Change Check

> >>

>>

️✔️PowerShell Core - Windows

>> >> >>

>>

>>

️✔️Windows PowerShell - Windows

>> >> >>

>

>

>

⚠️UX Metadata Check

> >>

>>

⚠️PowerShell Core - Windows

>> >>|Type|Module|ResourceType|SubResourceType|Command|Description| >>|---|---|---|---|---|---| >>|⚠️|Az.Resources|Microsoft.Resources|subscriptionsResourcegroups|Get-AzResourceGroup|The path /subscriptions/{subscriptionId}/resourceGroups/{name} doesn't contains the right resource tpye: Microsoft.Resources| >>|⚠️|Az.Resources|Microsoft.Resources|subscriptionsResourcegroups|Remove-AzResourceGroup|The path /subscriptions/{subscriptionId}/resourceGroups/{name} doesn't contains the right resource tpye: Microsoft.Resources| >> >>

>>

>>

⚠️Windows PowerShell - Windows

>> >>|Type|Module|ResourceType|SubResourceType|Command|Description| >>|---|---|---|---|---|---| >>|⚠️|Az.Resources|Microsoft.Resources|subscriptionsResourcegroups|Get-AzResourceGroup|The path /subscriptions/{subscriptionId}/resourceGroups/{name} doesn't contains the right resource tpye: Microsoft.Resources| >>|⚠️|Az.Resources|Microsoft.Resources|subscriptionsResourcegroups|Remove-AzResourceGroup|The path /subscriptions/{subscriptionId}/resourceGroups/{name} doesn't contains the right resource tpye: Microsoft.Resources| >> >>

>

>

>

⚠️Test

> >>

>>

⚠️ - Linux

>> >>|Type|Title|Current Coverage|Description| >>|---|---|---|---| >>|⚠️|Test Coverage Less Than 50%|49.76 %|Test coverage for the module cannot be lower than 50%.| >> >>

>>

>>

⚠️ - MacOS

>> >>|Type|Title|Current Coverage|Description| >>|---|---|---|---| >>|⚠️|Test Coverage Less Than 50%|49.76%|Test coverage for the module cannot be lower than 50%.| >> >>

>>

>>

⚠️PowerShell Core - Windows

>> >>|Type|Title|Current Coverage|Description| >>|---|---|---|---| >>|⚠️|Test Coverage Less Than 50%|49.76%|Test coverage for the module cannot be lower than 50%.| >> >>

>>

>>

⚠️Windows PowerShell - Windows

>> >>|Type|Title|Current Coverage|Description| >>|---|---|---|---| >>|⚠️|Test Coverage Less Than 50%|49.76%|Test coverage for the module cannot be lower than 50%.| >> >>

>

[VeryEarly]

/azp run azure-powershell - security-tools

[azure-pipelines[bot]]

Azure Pipelines successfully started running 1 pipeline(s).

[VeryEarly]

/azp run azure-powershell - security-tools

[azure-pipelines[bot]]

Azure Pipelines successfully started running 1 pipeline(s).