Fixed typos in a couple of variable names
Added called but undeclared variables to stop script failing Updated some commands to reflect current syntax
Added -DisableRbacAuthorization for KeyVault
Tested 7.4.5 core (MacOS) and 7.4.6 core (Windows)
Description
Fixed typos in a couple of variable names
Added called but undeclared variables to stop script failing Updated some commands to reflect current syntax
Added -DisableRbacAuthorization for KeyVault
Tested 7.4.5 core (MacOS) and 7.4.6 core (Windows)
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)
❌Az.Compute
>
> ️✔️Build
>
>>
>> ️✔️PowerShell Core - Windows
>>
>>
>>
>>
>> ️✔️Windows PowerShell - Windows
>>
>>
>>
>
>
> ❌Help Example Check
>
>>
>> ❌PowerShell Core - Windows
>>
>>|Type|Cmdlet|Example|Line|RuleName|Description|Extent|Remediation|
>>|---|---|---|---|---|---|---|---|
>>|❌|Set-AzVMOSDisk|5|70|Capitalization_Conventions_Violated|Set-AzVmSecurityProfile doesn't follow the Capitalization Conventions.|Set-AzVmSecurityProfile -VM $VirtualMachine -SecurityType $vmSecurityType|Check the Capitalization Conventions. Suggest format: Set-AzVMSecurityProfile|
>>|❌|Set-AzVMOSDisk|5|71|Capitalization_Conventions_Violated|Set-AzVmUefi doesn't follow the Capitalization Conventions.|Set-AzVmUefi -VM $VirtualMachine -EnableVtpm $true -EnableSecureBoot $true|Check the Capitalization Conventions. Suggest format: Set-AzVMUefi|
>>|❌|Set-AzVMOSDisk|5|74|Capitalization_Conventions_Violated|Get-AzVm doesn't follow the Capitalization Conventions.|Get-AzVm -ResourceGroupName $ResourceGroupName -Name $vmname|Check the Capitalization Conventions. Suggest format: Get-AzVM|
>>|⚠️|Set-AzVMOSDisk|5|42|Unassigned_Variable|Get-AzDiskEncryptionSet -ResourceGroupName $rgname is a null-valued parameter value.|-ResourceGroupName|Assign value for $rgname.|
>>|⚠️|Set-AzVMOSDisk|5|53|Unassigned_Variable|New-AzVirtualNetworkSubnetConfig -Name ($subnetPrefix + $ResourceGroupName) is a null-valued parameter value.|-Name|Assign value for ($subnetPrefix + $ResourceGroupName).|
>>|⚠️|Set-AzVMOSDisk|5|54|Unassigned_Variable|New-AzVirtualNetwork -Name ($vnetPrefix + $ResourceGroupName) is a null-valued parameter value.|-Name|Assign value for ($vnetPrefix + $ResourceGroupName).|
>>|⚠️|Set-AzVMOSDisk|5|55|Unassigned_Variable|Get-AzVirtualNetwork -Name ($vnetPrefix + $ResourceGroupName) is a null-valued parameter value.|-Name|Assign value for ($vnetPrefix + $ResourceGroupName).|
>>|⚠️|Set-AzVMOSDisk|5|57|Unassigned_Variable|New-AzPublicIpAddress -Name ($pubIpPrefix + $ResourceGroupName) is a null-valued parameter value.|-Name|Assign value for ($pubIpPrefix + $ResourceGroupName).|
>>|⚠️|Set-AzVMOSDisk|5|57|Unassigned_Variable|New-AzPublicIpAddress -DomainNameLabel $domainNameLabel2 is a null-valued parameter value.|-DomainNameLabel|Assign value for $domainNameLabel2.|
>>|⚠️|Set-AzVMOSDisk|5|58|Unassigned_Variable|Get-AzPublicIpAddress -Name ($pubIpPrefix + $ResourceGroupName) is a null-valued parameter value.|-Name|Assign value for ($pubIpPrefix + $ResourceGroupName).|
>>|⚠️|Set-AzVMOSDisk|5|62|Unassigned_Variable|New-AzNetworkInterface -Name ($nicPrefix + $ResourceGroupName) is a null-valued parameter value.|-Name|Assign value for ($nicPrefix + $ResourceGroupName).|
>>|⚠️|Set-AzVMOSDisk|5|63|Unassigned_Variable|Get-AzNetworkInterface -Name ($nicPrefix + $ResourceGroupName) is a null-valued parameter value.|-Name|Assign value for ($nicPrefix + $ResourceGroupName).|
>>
>>
>>
>> ❌Windows PowerShell - Windows
>>
>>|Type|Cmdlet|Example|Line|RuleName|Description|Extent|Remediation|
>>|---|---|---|---|---|---|---|---|
>>|❌|Set-AzVMOSDisk|5|70|Capitalization_Conventions_Violated|Set-AzVmSecurityProfile doesn't follow the Capitalization Conventions.|Set-AzVmSecurityProfile -VM $VirtualMachine -SecurityType $vmSecurityType|Check the Capitalization Conventions. Suggest format: Set-AzVMSecurityProfile|
>>|❌|Set-AzVMOSDisk|5|71|Capitalization_Conventions_Violated|Set-AzVmUefi doesn't follow the Capitalization Conventions.|Set-AzVmUefi -VM $VirtualMachine -EnableVtpm $true -EnableSecureBoot $true|Check the Capitalization Conventions. Suggest format: Set-AzVMUefi|
>>|❌|Set-AzVMOSDisk|5|74|Capitalization_Conventions_Violated|Get-AzVm doesn't follow the Capitalization Conventions.|Get-AzVm -ResourceGroupName $ResourceGroupName -Name $vmname|Check the Capitalization Conventions. Suggest format: Get-AzVM|
>>|⚠️|Set-AzVMOSDisk|5|42|Unassigned_Variable|Get-AzDiskEncryptionSet -ResourceGroupName $rgname is a null-valued parameter value.|-ResourceGroupName|Assign value for $rgname.|
>>|⚠️|Set-AzVMOSDisk|5|53|Unassigned_Variable|New-AzVirtualNetworkSubnetConfig -Name ($subnetPrefix + $ResourceGroupName) is a null-valued parameter value.|-Name|Assign value for ($subnetPrefix + $ResourceGroupName).|
>>|⚠️|Set-AzVMOSDisk|5|54|Unassigned_Variable|New-AzVirtualNetwork -Name ($vnetPrefix + $ResourceGroupName) is a null-valued parameter value.|-Name|Assign value for ($vnetPrefix + $ResourceGroupName).|
>>|⚠️|Set-AzVMOSDisk|5|55|Unassigned_Variable|Get-AzVirtualNetwork -Name ($vnetPrefix + $ResourceGroupName) is a null-valued parameter value.|-Name|Assign value for ($vnetPrefix + $ResourceGroupName).|
>>|⚠️|Set-AzVMOSDisk|5|57|Unassigned_Variable|New-AzPublicIpAddress -Name ($pubIpPrefix + $ResourceGroupName) is a null-valued parameter value.|-Name|Assign value for ($pubIpPrefix + $ResourceGroupName).|
>>|⚠️|Set-AzVMOSDisk|5|57|Unassigned_Variable|New-AzPublicIpAddress -DomainNameLabel $domainNameLabel2 is a null-valued parameter value.|-DomainNameLabel|Assign value for $domainNameLabel2.|
>>|⚠️|Set-AzVMOSDisk|5|58|Unassigned_Variable|Get-AzPublicIpAddress -Name ($pubIpPrefix + $ResourceGroupName) is a null-valued parameter value.|-Name|Assign value for ($pubIpPrefix + $ResourceGroupName).|
>>|⚠️|Set-AzVMOSDisk|5|62|Unassigned_Variable|New-AzNetworkInterface -Name ($nicPrefix + $ResourceGroupName) is a null-valued parameter value.|-Name|Assign value for ($nicPrefix + $ResourceGroupName).|
>>|⚠️|Set-AzVMOSDisk|5|63|Unassigned_Variable|Get-AzNetworkInterface -Name ($nicPrefix + $ResourceGroupName) is a null-valued parameter value.|-Name|Assign value for ($nicPrefix + $ResourceGroupName).|
>>
>>
>
>
> ️✔️Help File Existence Check
>
>>
>> ️✔️PowerShell Core - Windows
>>
>>
>>
>>
>> ️✔️Windows PowerShell - Windows
>>
>>
>>
>
Fixed typos in a couple of variable names Added called but undeclared variables to stop script failing Updated some commands to reflect current syntax Added -DisableRbacAuthorization for KeyVault Tested 7.4.5 core (MacOS) and 7.4.6 core (Windows)
Description
Fixed typos in a couple of variable names Added called but undeclared variables to stop script failing Updated some commands to reflect current syntax Added -DisableRbacAuthorization for KeyVault Tested 7.4.5 core (MacOS) and 7.4.6 core (Windows)
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)
[ X] Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:SHOULD update
ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT adjust version of module manually in pull request