Question: Is autoUpgradeMinorVersion false for ServiceFabricNode extension intentional?

mkosieradzki commented 7 years ago

Issue Details

autoUpgradeMinorVersion for ServiceFabricNode extension is set to false. Is this intentional? If yes, why? All other auto upgrades settings are enabled by default?

@ChackDan

ChackDan commented 7 years ago

Evan – this template is not authored by me or the SF team. Can you review it and answer this question.

From: mkosieradzki [mailto:notifications@github.com] Sent: Monday, April 24, 2017 9:18 AM To: Azure/azure-quickstart-templates azure-quickstart-templates@noreply.github.com Cc: Chacko Daniel chackdan@microsoft.com; Mention mention@noreply.github.com Subject: [Azure/azure-quickstart-templates] Question: Is autoUpgradeMinorVersion false for ServiceFabricNode extension intentional? (#3374)

service-fabric-vmss-omshttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-quickstart-templates%2Fblob%2Fmaster%2Fservice-fabric-vmss-oms%2Fazuredeploy.json&data=02%7C01%7Cchackdan%40microsoft.com%7Cc48a17dda3694a82a74608d48b2d771e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636286474767713332&sdata=7l4fM2gkrue6zGVLUoO0KwscMAlZZcniYxvf89FEyFk%3D&reserved=0

Issue Details

autoUpgradeMinorVersion for ServiceFabricNode extension is set to false. Is this intentional? If yes, why? All other auto upgrades settings are enabled by default?

@ChackDanhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FChackDan&data=02%7C01%7Cchackdan%40microsoft.com%7Cc48a17dda3694a82a74608d48b2d771e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636286474767713332&sdata=%2F8w60tN9PmlggsFOtZBN5Ql1dxS1Yfxyd2F4WEgTwtA%3D&reserved=0

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-quickstart-templates%2Fissues%2F3374&data=02%7C01%7Cchackdan%40microsoft.com%7Cc48a17dda3694a82a74608d48b2d771e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636286474767713332&sdata=IyIy%2FGmBWZZzx8285yN7p0d6ZfJhjqLnkURFvGVUNIk%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKq9pnS2kmQhsp592NthQ1ySGOvH8ggYks5rzMsugaJpZM4NGZAT&data=02%7C01%7Cchackdan%40microsoft.com%7Cc48a17dda3694a82a74608d48b2d771e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636286474767713332&sdata=%2FYZCszY%2BNVljvADlNyWqto0tgT3dhAAtS47ABX41DhY%3D&reserved=0.

ChackDan commented 7 years ago

@Kristian Nesemailto:Kristian.Nese@microsoft.com: Any idea why in the Service Fabric Solution’s deployment template we set autoUpgradeMinorVersion for ServiceFabricNode to false?

From: Chacko Daniel Sent: Monday, April 24, 2017 12:31 PM To: Azure/azure-quickstart-templates reply@reply.github.com; Azure/azure-quickstart-templates azure-quickstart-templates@noreply.github.com Cc: Mention mention@noreply.github.com; Evan Hissey evanhi@microsoft.com; Deep Kapur dekapur@microsoft.com Subject: RE: [Azure/azure-quickstart-templates] Question: Is autoUpgradeMinorVersion false for ServiceFabricNode extension intentional? (#3374)

Evan – this template is not authored by me or the SF team. Can you review it and answer this question.

From: mkosieradzki [mailto:notifications@github.com] Sent: Monday, April 24, 2017 9:18 AM To: Azure/azure-quickstart-templates azure-quickstart-templates@noreply.github.com<mailto:azure-quickstart-templates@noreply.github.com> Cc: Chacko Daniel chackdan@microsoft.com<mailto:chackdan@microsoft.com>; Mention mention@noreply.github.com<mailto:mention@noreply.github.com> Subject: [Azure/azure-quickstart-templates] Question: Is autoUpgradeMinorVersion false for ServiceFabricNode extension intentional? (#3374)

service-fabric-vmss-omshttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-quickstart-templates%2Fblob%2Fmaster%2Fservice-fabric-vmss-oms%2Fazuredeploy.json&data=02%7C01%7Cchackdan%40microsoft.com%7Cc48a17dda3694a82a74608d48b2d771e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636286474767713332&sdata=7l4fM2gkrue6zGVLUoO0KwscMAlZZcniYxvf89FEyFk%3D&reserved=0

Issue Details

autoUpgradeMinorVersion for ServiceFabricNode extension is set to false. Is this intentional? If yes, why? All other auto upgrades settings are enabled by default?

@ChackDanhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FChackDan&data=02%7C01%7Cchackdan%40microsoft.com%7Cc48a17dda3694a82a74608d48b2d771e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636286474767713332&sdata=%2F8w60tN9PmlggsFOtZBN5Ql1dxS1Yfxyd2F4WEgTwtA%3D&reserved=0

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-quickstart-templates%2Fissues%2F3374&data=02%7C01%7Cchackdan%40microsoft.com%7Cc48a17dda3694a82a74608d48b2d771e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636286474767713332&sdata=IyIy%2FGmBWZZzx8285yN7p0d6ZfJhjqLnkURFvGVUNIk%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKq9pnS2kmQhsp592NthQ1ySGOvH8ggYks5rzMsugaJpZM4NGZAT&data=02%7C01%7Cchackdan%40microsoft.com%7Cc48a17dda3694a82a74608d48b2d771e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636286474767713332&sdata=%2FYZCszY%2BNVljvADlNyWqto0tgT3dhAAtS47ABX41DhY%3D&reserved=0.

ChackDan commented 7 years ago

If my memory serves me, then the basic of this template was exported through the Azure portal, as part of deploying Service Fabric from the marketplace.

I just ran through the experience again, and this is the output I get for the ServiceFabric extension:

                   {
                            "name": "[concat(parameters('vmNodeType0Name'),'_ServiceFabricNode')]",
                            "properties": {
                                "type": "ServiceFabricNode",
                                "autoUpgradeMinorVersion": false,
                                "protectedSettings": {
                                    "StorageAccountKey1": "[listKeys(resourceId('Microsoft.Storage/storageAccounts', parameters('supportLogStorageAccountName')),'2015-05-01-preview').key1]",
                                    "StorageAccountKey2": "[listKeys(resourceId('Microsoft.Storage/storageAccounts', parameters('supportLogStorageAccountName')),'2015-05-01-preview').key2]"
                                },
                                "publisher": "Microsoft.Azure.ServiceFabric",
                                "settings": {
                                    "clusterEndpoint": "[reference(parameters('clusterName')).clusterEndpoint]",
                                    "nodeTypeRef": "[parameters('vmNodeType0Name')]",
                                   "dataPath": "D:\\\\SvcFab",
                                    "durabilityLevel": "Bronze",
                                    "enableParallelJobs": true,
                                    "nicPrefixOverride": "[parameters('subnet0Prefix')]"
                                },
                                "typeHandlerVersion": "1.0"
                            }
                        }

If we recommend the autoUpgradeMinorVersion to be true, then we should fix this.

I can always update the templates in the quickstart repo to reflect this.

-kn

From: Evan Hissey Sent: 24 April 2017 21:40 To: Chacko Daniel chackdan@microsoft.com; Azure/azure-quickstart-templates reply@reply.github.com; Azure/azure-quickstart-templates azure-quickstart-templates@noreply.github.com; Kristian Nese Kristian.Nese@microsoft.com Cc: Mention mention@noreply.github.com; Deep Kapur dekapur@microsoft.com Subject: RE: [Azure/azure-quickstart-templates] Question: Is autoUpgradeMinorVersion false for ServiceFabricNode extension intentional? (#3374)

@Kristian Nesemailto:Kristian.Nese@microsoft.com: Any idea why in the Service Fabric Solution’s deployment template we set autoUpgradeMinorVersion for ServiceFabricNode to false?

From: Chacko Daniel Sent: Monday, April 24, 2017 12:31 PM To: Azure/azure-quickstart-templates reply@reply.github.com; Azure/azure-quickstart-templates azure-quickstart-templates@noreply.github.com<mailto:azure-quickstart-templates@noreply.github.com> Cc: Mention mention@noreply.github.com<mailto:mention@noreply.github.com>; Evan Hissey evanhi@microsoft.com<mailto:evanhi@microsoft.com>; Deep Kapur dekapur@microsoft.com<mailto:dekapur@microsoft.com> Subject: RE: [Azure/azure-quickstart-templates] Question: Is autoUpgradeMinorVersion false for ServiceFabricNode extension intentional? (#3374)

Evan – this template is not authored by me or the SF team. Can you review it and answer this question.

From: mkosieradzki [mailto:notifications@github.com] Sent: Monday, April 24, 2017 9:18 AM To: Azure/azure-quickstart-templates azure-quickstart-templates@noreply.github.com<mailto:azure-quickstart-templates@noreply.github.com> Cc: Chacko Daniel chackdan@microsoft.com<mailto:chackdan@microsoft.com>; Mention mention@noreply.github.com<mailto:mention@noreply.github.com> Subject: [Azure/azure-quickstart-templates] Question: Is autoUpgradeMinorVersion false for ServiceFabricNode extension intentional? (#3374)

service-fabric-vmss-omshttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-quickstart-templates%2Fblob%2Fmaster%2Fservice-fabric-vmss-oms%2Fazuredeploy.json&data=02%7C01%7Cchackdan%40microsoft.com%7Cc48a17dda3694a82a74608d48b2d771e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636286474767713332&sdata=7l4fM2gkrue6zGVLUoO0KwscMAlZZcniYxvf89FEyFk%3D&reserved=0

Issue Details

autoUpgradeMinorVersion for ServiceFabricNode extension is set to false. Is this intentional? If yes, why? All other auto upgrades settings are enabled by default?

@ChackDanhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FChackDan&data=02%7C01%7Cchackdan%40microsoft.com%7Cc48a17dda3694a82a74608d48b2d771e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636286474767713332&sdata=%2F8w60tN9PmlggsFOtZBN5Ql1dxS1Yfxyd2F4WEgTwtA%3D&reserved=0

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-quickstart-templates%2Fissues%2F3374&data=02%7C01%7Cchackdan%40microsoft.com%7Cc48a17dda3694a82a74608d48b2d771e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636286474767713332&sdata=IyIy%2FGmBWZZzx8285yN7p0d6ZfJhjqLnkURFvGVUNIk%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKq9pnS2kmQhsp592NthQ1ySGOvH8ggYks5rzMsugaJpZM4NGZAT&data=02%7C01%7Cchackdan%40microsoft.com%7Cc48a17dda3694a82a74608d48b2d771e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636286474767713332&sdata=%2FYZCszY%2BNVljvADlNyWqto0tgT3dhAAtS47ABX41DhY%3D&reserved=0.

ChackDan commented 7 years ago

Deep – can you follow up offline on this with Abhay and make a call on this.

From: Kristian Nese Sent: Monday, April 24, 2017 12:46 PM To: Evan Hissey evanhi@microsoft.com; Chacko Daniel chackdan@microsoft.com; Azure/azure-quickstart-templates reply@reply.github.com; Azure/azure-quickstart-templates azure-quickstart-templates@noreply.github.com Cc: Mention mention@noreply.github.com; Deep Kapur dekapur@microsoft.com Subject: RE: [Azure/azure-quickstart-templates] Question: Is autoUpgradeMinorVersion false for ServiceFabricNode extension intentional? (#3374)

If my memory serves me, then the basic of this template was exported through the Azure portal, as part of deploying Service Fabric from the marketplace.

I just ran through the experience again, and this is the output I get for the ServiceFabric extension:

                   {
                            "name": "[concat(parameters('vmNodeType0Name'),'_ServiceFabricNode')]",
                            "properties": {
                                "type": "ServiceFabricNode",
                                "autoUpgradeMinorVersion": false,
                                "protectedSettings": {
                                    "StorageAccountKey1": "[listKeys(resourceId('Microsoft.Storage/storageAccounts', parameters('supportLogStorageAccountName')),'2015-05-01-preview').key1]",
                                    "StorageAccountKey2": "[listKeys(resourceId('Microsoft.Storage/storageAccounts', parameters('supportLogStorageAccountName')),'2015-05-01-preview').key2]"
                                },
                                "publisher": "Microsoft.Azure.ServiceFabric",
                                "settings": {
                                    "clusterEndpoint": "[reference(parameters('clusterName')).clusterEndpoint]",
                                    "nodeTypeRef": "[parameters('vmNodeType0Name')]",
                                   "dataPath": "D:\\\\SvcFab",
                                    "durabilityLevel": "Bronze",
                                    "enableParallelJobs": true,
                                    "nicPrefixOverride": "[parameters('subnet0Prefix')]"
                                },
                                "typeHandlerVersion": "1.0"
                            }
                        }

If we recommend the autoUpgradeMinorVersion to be true, then we should fix this.

I can always update the templates in the quickstart repo to reflect this.

-kn

From: Evan Hissey Sent: 24 April 2017 21:40 To: Chacko Daniel chackdan@microsoft.com<mailto:chackdan@microsoft.com>; Azure/azure-quickstart-templates reply@reply.github.com; Azure/azure-quickstart-templates azure-quickstart-templates@noreply.github.com<mailto:azure-quickstart-templates@noreply.github.com>; Kristian Nese Kristian.Nese@microsoft.com<mailto:Kristian.Nese@microsoft.com> Cc: Mention mention@noreply.github.com<mailto:mention@noreply.github.com>; Deep Kapur dekapur@microsoft.com<mailto:dekapur@microsoft.com> Subject: RE: [Azure/azure-quickstart-templates] Question: Is autoUpgradeMinorVersion false for ServiceFabricNode extension intentional? (#3374)

@Kristian Nesemailto:Kristian.Nese@microsoft.com: Any idea why in the Service Fabric Solution’s deployment template we set autoUpgradeMinorVersion for ServiceFabricNode to false?

From: Chacko Daniel Sent: Monday, April 24, 2017 12:31 PM To: Azure/azure-quickstart-templates reply@reply.github.com; Azure/azure-quickstart-templates azure-quickstart-templates@noreply.github.com<mailto:azure-quickstart-templates@noreply.github.com> Cc: Mention mention@noreply.github.com<mailto:mention@noreply.github.com>; Evan Hissey evanhi@microsoft.com<mailto:evanhi@microsoft.com>; Deep Kapur dekapur@microsoft.com<mailto:dekapur@microsoft.com> Subject: RE: [Azure/azure-quickstart-templates] Question: Is autoUpgradeMinorVersion false for ServiceFabricNode extension intentional? (#3374)

Evan – this template is not authored by me or the SF team. Can you review it and answer this question.

From: mkosieradzki [mailto:notifications@github.com] Sent: Monday, April 24, 2017 9:18 AM To: Azure/azure-quickstart-templates azure-quickstart-templates@noreply.github.com<mailto:azure-quickstart-templates@noreply.github.com> Cc: Chacko Daniel chackdan@microsoft.com<mailto:chackdan@microsoft.com>; Mention mention@noreply.github.com<mailto:mention@noreply.github.com> Subject: [Azure/azure-quickstart-templates] Question: Is autoUpgradeMinorVersion false for ServiceFabricNode extension intentional? (#3374)

service-fabric-vmss-omshttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-quickstart-templates%2Fblob%2Fmaster%2Fservice-fabric-vmss-oms%2Fazuredeploy.json&data=02%7C01%7Cchackdan%40microsoft.com%7Cc48a17dda3694a82a74608d48b2d771e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636286474767713332&sdata=7l4fM2gkrue6zGVLUoO0KwscMAlZZcniYxvf89FEyFk%3D&reserved=0

Issue Details

autoUpgradeMinorVersion for ServiceFabricNode extension is set to false. Is this intentional? If yes, why? All other auto upgrades settings are enabled by default?

@ChackDanhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FChackDan&data=02%7C01%7Cchackdan%40microsoft.com%7Cc48a17dda3694a82a74608d48b2d771e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636286474767713332&sdata=%2F8w60tN9PmlggsFOtZBN5Ql1dxS1Yfxyd2F4WEgTwtA%3D&reserved=0

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-quickstart-templates%2Fissues%2F3374&data=02%7C01%7Cchackdan%40microsoft.com%7Cc48a17dda3694a82a74608d48b2d771e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636286474767713332&sdata=IyIy%2FGmBWZZzx8285yN7p0d6ZfJhjqLnkURFvGVUNIk%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKq9pnS2kmQhsp592NthQ1ySGOvH8ggYks5rzMsugaJpZM4NGZAT&data=02%7C01%7Cchackdan%40microsoft.com%7Cc48a17dda3694a82a74608d48b2d771e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636286474767713332&sdata=%2FYZCszY%2BNVljvADlNyWqto0tgT3dhAAtS47ABX41DhY%3D&reserved=0.

ChackDan commented 7 years ago

Yes, will do.

Thanks!

From: Chacko Daniel Sent: Monday, April 24, 2017 1:36 PM To: Kristian Nese Kristian.Nese@microsoft.com; Evan Hissey evanhi@microsoft.com; Azure/azure-quickstart-templates reply@reply.github.com; Azure/azure-quickstart-templates azure-quickstart-templates@noreply.github.com Cc: Mention mention@noreply.github.com; Deep Kapur dekapur@microsoft.com Subject: RE: [Azure/azure-quickstart-templates] Question: Is autoUpgradeMinorVersion false for ServiceFabricNode extension intentional? (#3374)

Deep – can you follow up offline on this with Abhay and make a call on this.

From: Kristian Nese Sent: Monday, April 24, 2017 12:46 PM To: Evan Hissey evanhi@microsoft.com<mailto:evanhi@microsoft.com>; Chacko Daniel chackdan@microsoft.com<mailto:chackdan@microsoft.com>; Azure/azure-quickstart-templates reply@reply.github.com; Azure/azure-quickstart-templates azure-quickstart-templates@noreply.github.com<mailto:azure-quickstart-templates@noreply.github.com> Cc: Mention mention@noreply.github.com<mailto:mention@noreply.github.com>; Deep Kapur dekapur@microsoft.com<mailto:dekapur@microsoft.com> Subject: RE: [Azure/azure-quickstart-templates] Question: Is autoUpgradeMinorVersion false for ServiceFabricNode extension intentional? (#3374)

If my memory serves me, then the basic of this template was exported through the Azure portal, as part of deploying Service Fabric from the marketplace.

I just ran through the experience again, and this is the output I get for the ServiceFabric extension:

                   {
                            "name": "[concat(parameters('vmNodeType0Name'),'_ServiceFabricNode')]",
                            "properties": {
                                "type": "ServiceFabricNode",
                                "autoUpgradeMinorVersion": false,
                                "protectedSettings": {
                                    "StorageAccountKey1": "[listKeys(resourceId('Microsoft.Storage/storageAccounts', parameters('supportLogStorageAccountName')),'2015-05-01-preview').key1]",
                                    "StorageAccountKey2": "[listKeys(resourceId('Microsoft.Storage/storageAccounts', parameters('supportLogStorageAccountName')),'2015-05-01-preview').key2]"
                                },
                                "publisher": "Microsoft.Azure.ServiceFabric",
                                "settings": {
                                    "clusterEndpoint": "[reference(parameters('clusterName')).clusterEndpoint]",
                                    "nodeTypeRef": "[parameters('vmNodeType0Name')]",
                                   "dataPath": "D:\\\\SvcFab",
                                    "durabilityLevel": "Bronze",
                                    "enableParallelJobs": true,
                                    "nicPrefixOverride": "[parameters('subnet0Prefix')]"
                                },
                                "typeHandlerVersion": "1.0"
                            }
                        }

If we recommend the autoUpgradeMinorVersion to be true, then we should fix this.

I can always update the templates in the quickstart repo to reflect this.

-kn

From: Evan Hissey Sent: 24 April 2017 21:40 To: Chacko Daniel chackdan@microsoft.com<mailto:chackdan@microsoft.com>; Azure/azure-quickstart-templates reply@reply.github.com; Azure/azure-quickstart-templates azure-quickstart-templates@noreply.github.com<mailto:azure-quickstart-templates@noreply.github.com>; Kristian Nese Kristian.Nese@microsoft.com<mailto:Kristian.Nese@microsoft.com> Cc: Mention mention@noreply.github.com<mailto:mention@noreply.github.com>; Deep Kapur dekapur@microsoft.com<mailto:dekapur@microsoft.com> Subject: RE: [Azure/azure-quickstart-templates] Question: Is autoUpgradeMinorVersion false for ServiceFabricNode extension intentional? (#3374)

@Kristian Nesemailto:Kristian.Nese@microsoft.com: Any idea why in the Service Fabric Solution’s deployment template we set autoUpgradeMinorVersion for ServiceFabricNode to false?

From: Chacko Daniel Sent: Monday, April 24, 2017 12:31 PM To: Azure/azure-quickstart-templates reply@reply.github.com; Azure/azure-quickstart-templates azure-quickstart-templates@noreply.github.com<mailto:azure-quickstart-templates@noreply.github.com> Cc: Mention mention@noreply.github.com<mailto:mention@noreply.github.com>; Evan Hissey evanhi@microsoft.com<mailto:evanhi@microsoft.com>; Deep Kapur dekapur@microsoft.com<mailto:dekapur@microsoft.com> Subject: RE: [Azure/azure-quickstart-templates] Question: Is autoUpgradeMinorVersion false for ServiceFabricNode extension intentional? (#3374)

Evan – this template is not authored by me or the SF team. Can you review it and answer this question.

From: mkosieradzki [mailto:notifications@github.com] Sent: Monday, April 24, 2017 9:18 AM To: Azure/azure-quickstart-templates azure-quickstart-templates@noreply.github.com<mailto:azure-quickstart-templates@noreply.github.com> Cc: Chacko Daniel chackdan@microsoft.com<mailto:chackdan@microsoft.com>; Mention mention@noreply.github.com<mailto:mention@noreply.github.com> Subject: [Azure/azure-quickstart-templates] Question: Is autoUpgradeMinorVersion false for ServiceFabricNode extension intentional? (#3374)

service-fabric-vmss-omshttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-quickstart-templates%2Fblob%2Fmaster%2Fservice-fabric-vmss-oms%2Fazuredeploy.json&data=02%7C01%7Cchackdan%40microsoft.com%7Cc48a17dda3694a82a74608d48b2d771e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636286474767713332&sdata=7l4fM2gkrue6zGVLUoO0KwscMAlZZcniYxvf89FEyFk%3D&reserved=0

Issue Details

autoUpgradeMinorVersion for ServiceFabricNode extension is set to false. Is this intentional? If yes, why? All other auto upgrades settings are enabled by default?

@ChackDanhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FChackDan&data=02%7C01%7Cchackdan%40microsoft.com%7Cc48a17dda3694a82a74608d48b2d771e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636286474767713332&sdata=%2F8w60tN9PmlggsFOtZBN5Ql1dxS1Yfxyd2F4WEgTwtA%3D&reserved=0

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-quickstart-templates%2Fissues%2F3374&data=02%7C01%7Cchackdan%40microsoft.com%7Cc48a17dda3694a82a74608d48b2d771e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636286474767713332&sdata=IyIy%2FGmBWZZzx8285yN7p0d6ZfJhjqLnkURFvGVUNIk%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKq9pnS2kmQhsp592NthQ1ySGOvH8ggYks5rzMsugaJpZM4NGZAT&data=02%7C01%7Cchackdan%40microsoft.com%7Cc48a17dda3694a82a74608d48b2d771e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636286474767713332&sdata=%2FYZCszY%2BNVljvADlNyWqto0tgT3dhAAtS47ABX41DhY%3D&reserved=0.

ChackDan commented 7 years ago

Just talked to Abhay and seems like the template on Portal has been changed to set autoUpgradeMinorVersion to true as of last week, so that change should propagate through soon.

Kristian, I think it makes sense to change the template you have and set that parameter to true for now.

Thanks!

From: Chacko Daniel Sent: Monday, April 24, 2017 1:36 PM To: Kristian Nese Kristian.Nese@microsoft.com; Evan Hissey evanhi@microsoft.com; Azure/azure-quickstart-templates reply@reply.github.com; Azure/azure-quickstart-templates azure-quickstart-templates@noreply.github.com Cc: Mention mention@noreply.github.com; Deep Kapur dekapur@microsoft.com Subject: RE: [Azure/azure-quickstart-templates] Question: Is autoUpgradeMinorVersion false for ServiceFabricNode extension intentional? (#3374)

Deep – can you follow up offline on this with Abhay and make a call on this.

From: Kristian Nese Sent: Monday, April 24, 2017 12:46 PM To: Evan Hissey evanhi@microsoft.com<mailto:evanhi@microsoft.com>; Chacko Daniel chackdan@microsoft.com<mailto:chackdan@microsoft.com>; Azure/azure-quickstart-templates reply@reply.github.com; Azure/azure-quickstart-templates azure-quickstart-templates@noreply.github.com<mailto:azure-quickstart-templates@noreply.github.com> Cc: Mention mention@noreply.github.com<mailto:mention@noreply.github.com>; Deep Kapur dekapur@microsoft.com<mailto:dekapur@microsoft.com> Subject: RE: [Azure/azure-quickstart-templates] Question: Is autoUpgradeMinorVersion false for ServiceFabricNode extension intentional? (#3374)

If my memory serves me, then the basic of this template was exported through the Azure portal, as part of deploying Service Fabric from the marketplace.

I just ran through the experience again, and this is the output I get for the ServiceFabric extension:

                   {
                            "name": "[concat(parameters('vmNodeType0Name'),'_ServiceFabricNode')]",
                            "properties": {
                                "type": "ServiceFabricNode",
                                "autoUpgradeMinorVersion": false,
                                "protectedSettings": {
                                    "StorageAccountKey1": "[listKeys(resourceId('Microsoft.Storage/storageAccounts', parameters('supportLogStorageAccountName')),'2015-05-01-preview').key1]",
                                    "StorageAccountKey2": "[listKeys(resourceId('Microsoft.Storage/storageAccounts', parameters('supportLogStorageAccountName')),'2015-05-01-preview').key2]"
                                },
                                "publisher": "Microsoft.Azure.ServiceFabric",
                                "settings": {
                                    "clusterEndpoint": "[reference(parameters('clusterName')).clusterEndpoint]",
                                    "nodeTypeRef": "[parameters('vmNodeType0Name')]",
                                   "dataPath": "D:\\\\SvcFab",
                                    "durabilityLevel": "Bronze",
                                    "enableParallelJobs": true,
                                    "nicPrefixOverride": "[parameters('subnet0Prefix')]"
                                },
                                "typeHandlerVersion": "1.0"
                            }
                        }

If we recommend the autoUpgradeMinorVersion to be true, then we should fix this.

I can always update the templates in the quickstart repo to reflect this.

-kn

From: Evan Hissey Sent: 24 April 2017 21:40 To: Chacko Daniel chackdan@microsoft.com<mailto:chackdan@microsoft.com>; Azure/azure-quickstart-templates reply@reply.github.com; Azure/azure-quickstart-templates azure-quickstart-templates@noreply.github.com<mailto:azure-quickstart-templates@noreply.github.com>; Kristian Nese Kristian.Nese@microsoft.com<mailto:Kristian.Nese@microsoft.com> Cc: Mention mention@noreply.github.com<mailto:mention@noreply.github.com>; Deep Kapur dekapur@microsoft.com<mailto:dekapur@microsoft.com> Subject: RE: [Azure/azure-quickstart-templates] Question: Is autoUpgradeMinorVersion false for ServiceFabricNode extension intentional? (#3374)

@Kristian Nesemailto:Kristian.Nese@microsoft.com: Any idea why in the Service Fabric Solution’s deployment template we set autoUpgradeMinorVersion for ServiceFabricNode to false?

From: Chacko Daniel Sent: Monday, April 24, 2017 12:31 PM To: Azure/azure-quickstart-templates reply@reply.github.com; Azure/azure-quickstart-templates azure-quickstart-templates@noreply.github.com<mailto:azure-quickstart-templates@noreply.github.com> Cc: Mention mention@noreply.github.com<mailto:mention@noreply.github.com>; Evan Hissey evanhi@microsoft.com<mailto:evanhi@microsoft.com>; Deep Kapur dekapur@microsoft.com<mailto:dekapur@microsoft.com> Subject: RE: [Azure/azure-quickstart-templates] Question: Is autoUpgradeMinorVersion false for ServiceFabricNode extension intentional? (#3374)

Evan – this template is not authored by me or the SF team. Can you review it and answer this question.

From: mkosieradzki [mailto:notifications@github.com] Sent: Monday, April 24, 2017 9:18 AM To: Azure/azure-quickstart-templates azure-quickstart-templates@noreply.github.com<mailto:azure-quickstart-templates@noreply.github.com> Cc: Chacko Daniel chackdan@microsoft.com<mailto:chackdan@microsoft.com>; Mention mention@noreply.github.com<mailto:mention@noreply.github.com> Subject: [Azure/azure-quickstart-templates] Question: Is autoUpgradeMinorVersion false for ServiceFabricNode extension intentional? (#3374)

service-fabric-vmss-omshttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-quickstart-templates%2Fblob%2Fmaster%2Fservice-fabric-vmss-oms%2Fazuredeploy.json&data=02%7C01%7Cchackdan%40microsoft.com%7Cc48a17dda3694a82a74608d48b2d771e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636286474767713332&sdata=7l4fM2gkrue6zGVLUoO0KwscMAlZZcniYxvf89FEyFk%3D&reserved=0

Issue Details

autoUpgradeMinorVersion for ServiceFabricNode extension is set to false. Is this intentional? If yes, why? All other auto upgrades settings are enabled by default?

@ChackDanhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FChackDan&data=02%7C01%7Cchackdan%40microsoft.com%7Cc48a17dda3694a82a74608d48b2d771e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636286474767713332&sdata=%2F8w60tN9PmlggsFOtZBN5Ql1dxS1Yfxyd2F4WEgTwtA%3D&reserved=0

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-quickstart-templates%2Fissues%2F3374&data=02%7C01%7Cchackdan%40microsoft.com%7Cc48a17dda3694a82a74608d48b2d771e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636286474767713332&sdata=IyIy%2FGmBWZZzx8285yN7p0d6ZfJhjqLnkURFvGVUNIk%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKq9pnS2kmQhsp592NthQ1ySGOvH8ggYks5rzMsugaJpZM4NGZAT&data=02%7C01%7Cchackdan%40microsoft.com%7Cc48a17dda3694a82a74608d48b2d771e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636286474767713332&sdata=%2FYZCszY%2BNVljvADlNyWqto0tgT3dhAAtS47ABX41DhY%3D&reserved=0.

Azure / azure-quickstart-templates

Question: Is autoUpgradeMinorVersion false for ServiceFabricNode extension intentional? #3374

Issue Details