search

Azure / azure-relay-java

Azure Relay Java SDK
MIT License
8 stars 9 forks source link

Mistakes in exception handling HybridConnectionListener #71

Open consultantleon opened 4 years ago

consultantleon commented 4 years ago

We noticed a race condition occurring after a network disruption, the HybridConnectionListener continues to loop and does not properly detect the error and commence a fresh reconnection cycle.

The reason seems to be in the wrong runtime exceptions being caught in HybridConnectionListener.java.

I also removed all unnecessary throws and replaced catch(Throwable) by more specific exception after having run the code agains our sonar setup.

I advised our Microsoft representative to run your code against a standard code checking tool such as Sonar to take this kind of mistakes out the code! See attached my version of HybridConnectionListener.java - which we updated after your dev commit of Feb 7 (== 0.3 release version). HybridConnectionListener.java.txt

jfggdl commented 4 years ago

@consultantleon, Thank you for reporting these code problems. Would you be able to create a PR?

consultantleon commented 4 years ago

sorry didn't see your comment - I wasn't sure how to create a branch & PR on this project. Was any action taken by you to correct the issue yet?