Azure / azure-relay-node

☁️Node.js library for Azure Relay Hybrid Connections
https://docs.microsoft.com/en-us/azure/service-bus-relay/relay-what-is-it
MIT License
12 stars 15 forks source link

Add a possibility to handle `The token has an invalid signature` error on creating relayedServer #28

Open andrei-rodionov-idexx opened 5 years ago

andrei-rodionov-idexx commented 5 years ago

Actual Behavior

const RelayedServer = require('hyco-websocket').relayedServer;
const wsServer = new RelayedServer({
  server: ...,
  token: () => WebSocket.createRelayToken(...),
});

If token is invalid the following raw error appears in log at WebSocketClient.failHandshake (C:\Projects\IDEXX\CornerstoneCloud\infra\scripts\websocket-port-bridge\node_modules\hyco-websocket\node_modules\websocket\lib\WebSocketClient.js:339:32)

Expected Behavior

Should be able to handle this error in client code. The issue is in HybridConnectionsWebSocketServer.js module (lines 258-260). Can we just add a line server.emit('error', event); in client.on('connectFailed'... event

Versions

jfggdl commented 3 years ago

We will be planning for improvements to our SDKs and this item is already on our backlog.