search

Azure / azure-relay-node

☁️Node.js library for Azure Relay Hybrid Connections
https://docs.microsoft.com/en-us/azure/service-bus-relay/relay-what-is-it
MIT License
12 stars 15 forks source link

Prevent small HTTP requests from unnecessary rendezvous #33

Closed bainian12345 closed 5 years ago

bainian12345 commented 5 years ago

Prevent small GET and POST requests from creating separate websocket connections for each request.

dlstucki commented 5 years ago

function controlChannelRequest(server, message) {

Is there a test case for small request (control connection) and large response (rendezvous connection)? I think having these will provide the minimum coverage for all scenarios:

  1. Control Connection Request + Control Connection Response (get.test.js, post.test.js)
  2. Control Connection Request + Rendezvous Connection Response (I don't think this is covered right now)
  3. Rendezvous Connection Request + Rendezvous Connection Small Response (largepost.test.js, chunkedpost.test.js)
  4. Rendezvous Connection Request + Rendezvous Connection Large Response. I won't be upset if ommitted since it should follow the same path as test # 3 mentioned above. #Resolved

Refers to: hyco-https/lib/HybridConnectionHttpsServer.js:594 in 949a04c. [](commit_id = 949a04c706739bfadef4390422eec4eebf7532be, deletion_comment = False)