search

Azure / azure-relay-node

☁️Node.js library for Azure Relay Hybrid Connections
https://docs.microsoft.com/en-us/azure/service-bus-relay/relay-what-is-it
MIT License
12 stars 14 forks source link

Build fails because /lib/_hyco_errors references an unknown module. #40

Closed mikewalpole-systemc closed 4 years ago

mikewalpole-systemc commented 4 years ago

Actual Behavior

  1. The build of our product fails when we include hyco-https as a dependency because the bundling process tries to resolve all module references in the dependencies. File '_hyco_errors.js' has a reference to 'internal/util', which doesn't exist - I assume this is meant to represent the NodeJs 'util' module.
  2. The code in _hyco_errors.js which would try to load 'internal/util' appears to be not referenced anywhere else in hyco-https. I can work around this by registering 'internal/util' as an alias to be resolved by Webpack, but this seems like the wrong solution.

Expected Behavior

  1. The reference to the unresolved module is removed from _hyco_errors.js, and the apparently redundant code removed - or should the reference actually be to 'util' rather than 'internal/util' (there are references to just 'util' elsewhere)?

Versions

bainian12345 commented 4 years ago

Removed the dependency in 1.4.2