Azure / azure-remote-rendering

SDK and samples for Azure Remote Rendering
MIT License
107 stars 39 forks source link

[Conversion Problem] Ply with diffuse_red, diffuse_green, diffuse_blue fails to convert #78

Closed WikkidEdd closed 2 years ago

WikkidEdd commented 2 years ago

I just came across a point cloud on SketchFab which fails to convert. https://sketchfab.com/3d-models/avva-pointcloud-small-238d2592929e4b7c9fd6623be28d256c

Looking at the supported point cloud spec in the docs vs the header in the ply, it looks to be because it is using

property uchar diffuse_red
property uchar diffuse_green
property uchar diffuse_blue

instead of

property uchar red
property uchar green
property uchar blue

I don't know if "diffuse_color" is much of a standard, but it would be good if it could be treated "color" to improve compatibility.

AdamCichocki commented 2 years ago

Hi Edd, thanks for reporting the issue. It will be addressed in next release.

AdamCichocki commented 2 years ago

Hi Edd, changes you proposed are now deployed and active.