search

Azure / azure-remote-rendering

SDK and samples for Azure Remote Rendering
MIT License
106 stars 38 forks source link

Fixed parameter parsing if json file is used #96

Closed MichaelZp0 closed 1 year ago

MichaelZp0 commented 1 year ago

Closes #94

Thanks LeGrandMAG for finding this issue and double thanks for proposing a fix. That fix would resolve you situation, but would break other use cases.

The links are wrong yes, but the cause of it is, that if the remoteRenderingDomain or arrAccountDomain parameter is only specified in the json file and not on the command line, the function (ToDomain) is never called on these values. The ToDomain function will sanitize them and add the missing https://.

That was absolutely a bug in the script and sorry about that.

We will also update the documentation accordingly.

magmukendi commented 1 year ago

My bad, I did not carrefully check the every function that was involved before making the http request. But it's nice that you fixed it.