Updated the fix for parsing the url if json file is used

Azure / azure-remote-rendering

SDK and samples for Azure Remote Rendering

MIT License

106 stars 38 forks source link

Updated the fix for parsing the url if json file is used #98

Closed magmukendi closed 1 year ago

magmukendi commented 1 year ago

Because the TrimStart() behavior on line 14 is weird, I proposed a fix by adding a if-statement and some regex.

This PR is for solving issue #94 Please review and let me know.

MichaelZp0 commented 1 year ago

Looks good to me.

Sadly I can't merge this PR and have to open another one. This is is due to an internal policy, that all scripts/binaries have to be signed (See the big blob of data at the bottom of the script). I will sign them asap and push them here.

magmukendi commented 1 year ago

Oh, okay. Thanks for the fast reply.

The remote rendering services is super useful, kudos for that

MichaelZp0 commented 1 year ago

Thanks we'll try to keep it super useful or make it even better :).

Your fix was added to the latest release and should now be in completely.