search

Azure / azure-resource-manager-schemas

Schemas used to author and validate Resource Manager Templates. These schemas power the intellisense and syntax completion in our ARM Tools VSCode extension, as well as the Export Template API
MIT License
610 stars 517 forks source link

Onboarding Microsoft.ManagedIdentity #2444

Open isolenov opened 2 years ago

isolenov commented 2 years ago

We would like to onboard azure Microsoft.ManagedIdentity to daily generation.

Microsoft.ManagedIdentity is opt-out according to https://github.com/Azure/azure-resource-manager-schemas/blob/main/generator/autogenlist.ts

Taking in account that template schema was not updated since 2018 can we have some kind of changes preview to make sure that current templates would not break?

Please let me know of any potential issues and things worth doublechecking

Currently we are interested in adding a new sub resource type https://github.com/Azure/azure-rest-api-specs/tree/e30340ef579e59a9a937aaec9a4caf0842cffa39/specification/msi/resource-manager/Microsoft.ManagedIdentity/preview/2022-01-31-preview

anthony-c-martin commented 2 years ago

You should be able to:

  1. Fork this repo
  2. Make the change to autogenlist.ts to enable your RP
  3. Run the generate-types GitHub action in your fork, with path set to "msi": image
  4. When complete, this will submit a PR to your fork with the proposed changes for you to review
serhangursoy-microsoft commented 2 years ago

Hey @anthony-c-martin , thanks for explaining the initial steps. Here is the PR generated by Github Actions on our fork: serhangursoy-microsoft/azure-resource-manager-schemas Can you provide the next steps for completing our onboarding for the daily generation on main repo?

anthony-c-martin commented 2 years ago

@serhangursoy-microsoft - looks good, thanks for sharing. Next steps - merge that PR into your fork, and submit a PR to this repo containing those changes + removing the disabledForAutogen config

serhangursoy-microsoft commented 2 years ago

@anthony-c-martin thanks, here is the PR to this repo containing changes from forked repo's main: https://github.com/Azure/azure-resource-manager-schemas/pull/2445