search

Azure / azure-rest-api-specs

The source for REST API specifications for Microsoft Azure.
MIT License
2.6k stars 5.01k forks source link

Virtual Desktop Host Pool API should allow the name which is longer than 24 characters #11642

Open neil-yechenwei opened 3 years ago

neil-yechenwei commented 3 years ago

After tested with azure rest api, I found Virtual Desktop Host Pool API doesn't allow the name which is longer than 24 characters. But Azure Portal allows to create this resource with name which is longer than 24 characters after tested on Azure Portal. So I assume it's the swagger property validation issue.

Error message:

desktopvirtualization.HostPoolsClient#CreateOrUpdate: Invalid input: autorest/validation: validation failed: parameter=hostPoolName constraint=MaxLength value="wvdpool-pooled-dev-s-eastus" details: value length must be less than or equal to 24

After checked azure-rest-api-spec, seems there is a length validation on host pool name. Maybe it's the root cause.

ArcturusZhang commented 3 years ago

Hi @akning-ms we do not have a service tag for RP desktopvirtualization right now, is it possible that we could add them?

raych1 commented 3 years ago

@datr93, I found you updated the correspondent swagger. Can you please have a look at this issue or help escalate to related person? Thanks in advance.

datr93 commented 3 years ago

resourceName | The name of the resource. The name cannot include: '<', '>', '%', '&', ':', '\', '?', '/' OR any control characters. The max length is 260 characters. All other characters are allowed. The RP is expected to be more restrictive and have its own validation.

checking.

ArcturusZhang commented 3 years ago

resourceName | The name of the resource. The name cannot include: '<', '>', '%', '&', ':', '', '?', '/' OR any control characters. The max length is 260 characters. All other characters are allowed. The RP is expected to be more restrictive and have its own validation.

checking.

Would there be a fix for this soon? This is blocking all the downstream customers that are using Azure SDKs

raych1 commented 3 years ago

resourceName | The name of the resource. The name cannot include: '<', '>', '%', '&', ':', '', '?', '/' OR any control characters. The max length is 260 characters. All other characters are allowed. The RP is expected to be more restrictive and have its own validation.

checking.

Thanks @datr93 , I assigned this issue to you for the follow-ups.

ArcturusZhang commented 3 years ago

And @datr93 please note there are multiple of resources in the desktop virtualization with wrong constraints now. We have another report of this kind issues here for the Virtual Desktop Application Group resource.

ghost commented 3 years ago

Hi, neil-yechenwei. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.