search

Azure / azure-rest-api-specs

The source for REST API specifications for Microsoft Azure.
MIT License
2.61k stars 5.02k forks source link

ServiceFabric: duplicate Operations_List in spec #11811

Open weidongxu-microsoft opened 3 years ago

weidongxu-microsoft commented 3 years ago

Same Operations_List operation in application.json and cluster.json. Since in README these 2 files are commonly under same tag, it causes duplication when generating SDK.

https://github.com/Azure/azure-rest-api-specs/blob/master/specification/servicefabric/resource-manager/Microsoft.ServiceFabric/stable/2020-03-01/application.json#L44

https://github.com/Azure/azure-rest-api-specs/blob/master/specification/servicefabric/resource-manager/Microsoft.ServiceFabric/stable/2020-03-01/cluster.json#L472

error log

WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.

ERROR (): Duplicate Operation 'List' detected.
FATAL: Error: 1 errors occured -- cannot continue.
  Error: Plugin checker reported failure.
ctaggart commented 3 years ago

I think #11581 attempted to fix this and another issue. It may be good to fix the two issues separately in two different pull requests.

ghost commented 3 years ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @QingChenmsft, @vaishnavk, @juhacket.

Issue Details
Same `Operations_List` operation in application.json and cluster.json. Since in README these 2 files are commonly under same tag, it causes duplication when generating SDK. https://github.com/Azure/azure-rest-api-specs/blob/master/specification/servicefabric/resource-manager/Microsoft.ServiceFabric/stable/2020-03-01/application.json#L44 https://github.com/Azure/azure-rest-api-specs/blob/master/specification/servicefabric/resource-manager/Microsoft.ServiceFabric/stable/2020-03-01/cluster.json#L472 error log ``` WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail. ERROR (): Duplicate Operation 'List' detected. FATAL: Error: 1 errors occured -- cannot continue. Error: Plugin checker reported failure. ```
Author: weidongxu-microsoft
Assignees: -
Labels: `Service Attention`, `Service Fabric`
Milestone: -
weidongxu-microsoft commented 3 years ago

Maybe it would help to factor the common part out to an operation.json in the new api-version.

network did this: https://github.com/Azure/azure-rest-api-specs/blob/master/specification/network/resource-manager/Microsoft.Network/stable/2020-07-01/operation.json

ghost commented 3 years ago

Hi, weidongxu-microsoft. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.