Azure / azure-rest-api-specs

The source for REST API specifications for Microsoft Azure.
MIT License
2.7k stars 5.12k forks source link

key vault managed hsm api issue #13365

Open njuCZ opened 3 years ago

njuCZ commented 3 years ago

https://github1s.com/Azure/azure-rest-api-specs/blob/HEAD/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2020-04-01-preview/managedHsm.json

apiversion: 2020-04-01-preview

issue:

  1. just want to double confirm that softDeleteRetentionInDays could not be updated?
  2. when changing enablePurgeProtection from false to true, the rest api could succeed, but the response is still false
  3. for delete rest api, it's long running process. sometimes the api will return 404 rather than 200 as the final state of the long polling. We expect it should be 200
  4. when updating, the swagger is a long running process. The sdk will fire an update request and then a series of get operation, however the get operation reports error: can not parse version
ghost commented 3 years ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @RandalliLama, @schaabs, @jlichwa.

Issue Details
https://github1s.com/Azure/azure-rest-api-specs/blob/HEAD/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2020-04-01-preview/managedHsm.json apiversion: 2020-04-01-preview issue: 1. just want to double confirm that `softDeleteRetentionInDays` could not be updated? 2. when changing `enablePurgeProtection` from `false` to `true`, the rest api could succeed, but the response is still `false` 3. for delete rest api, it's long running process. sometimes the api will return 404 rather than 200 as the final state of the long polling. We expect it should be 200
Author: njuCZ
Assignees: -
Labels: `KeyVault`, `Service Attention`, `needs-triage`
Milestone: -
ghost commented 3 years ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @RandalliLama, @schaabs, @jlichwa.

Issue Details
https://github1s.com/Azure/azure-rest-api-specs/blob/HEAD/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2020-04-01-preview/managedHsm.json apiversion: 2020-04-01-preview issue: 1. just want to double confirm that `softDeleteRetentionInDays` could not be updated? 2. when changing `enablePurgeProtection` from `false` to `true`, the rest api could succeed, but the response is still `false` 3. for delete rest api, it's long running process. sometimes the api will return 404 rather than 200 as the final state of the long polling. We expect it should be 200 4. when updating, the swagger is a long running process. The sdk will fire an update request and then a series of get operation, however the get operation reports error: can not parse version
Author: njuCZ
Assignees: -
Labels: `KeyVault`, `Service Attention`
Milestone: -
jlichwa commented 3 years ago

@njuCZ Response from engineering team:

  1. just want to double confirm that softDeleteRetentionInDays could not be updated? softDeleteRetentionInDays cannot be updated after resource creation
  2. when changing enablePurgeProtection from false to true, the rest api could succeed, but the response is still false The ability to update enablePurgeProtection is now live in all regions
  3. for delete rest api, it's long running process. sometimes the api will return 404 rather than 200 as the final state of the long polling. We expect it should be 200 This should no longer be happening, we expect that the possible responses for polling for delete should return 204 or conflict
  4. when updating, the swagger is a long running process. The sdk will fire an update request and then a series of get operation, however the get operation reports error: can not parse version This bug is now being fixed by our team. The bug affects only the polling for the state of the update and the update operation should still complete successfully.
jlichwa commented 3 years ago

+@vickm for MHSM issues

xiaxyi commented 3 years ago

@njuCZ Response from engineering team:

  1. just want to double confirm that softDeleteRetentionInDays could not be updated? softDeleteRetentionInDays cannot be updated after resource creation
  2. when changing enablePurgeProtection from false to true, the rest api could succeed, but the response is still false The ability to update enablePurgeProtection is now live in all regions
  3. for delete rest api, it's long running process. sometimes the api will return 404 rather than 200 as the final state of the long polling. We expect it should be 200 This should no longer be happening, we expect that the possible responses for polling for delete should return 204 or conflict
  4. when updating, the swagger is a long running process. The sdk will fire an update request and then a series of get operation, however the get operation reports error: can not parse version This bug is now being fixed by our team. The bug affects only the polling for the state of the update and the update operation should still complete successfully.

@jlichwa Thanks for looking into this issue, may I know if the issue is now fixed, if so, may I know the API version?