search

Azure / azure-rest-api-specs

The source for REST API specifications for Microsoft Azure.
MIT License
2.68k stars 5.1k forks source link

MarketplaceOrdering 2021-01-01 return property `accepted` always false even for accepted terms #14108

Open yungezz opened 3 years ago

yungezz commented 3 years ago

2 issues:

HTTP Method:
PUT

Absolute Uri:
https://management.azure.com/subscriptions/ec0aa5f7-9e78-40c9-85cd-535c6305b380/providers/Microsoft.MarketplaceOrdering
/offerTypes/virtualmachine/publishers/checkpoint/offers/vsec/plans/management/agreements/current?api-version=2015-06-01

Headers:
x-ms-client-request-id        : 425cd3a2-9440-4f5a-bb79-1e7085d09a58
accept-language               : en-US

Body:
{
  "properties": {
    "publisher": "checkpoint",
    "product": "vsec",
    "plan": "management",
    "licenseTextLink":
"https://mpcprodsa.blob.core.windows.net/legalterms/3E5ED_legalterms_CHECKPOINT%253a24VSEC%253a24MANAGEMENT%253a2476HGN
ZSJREVLUQYE5WCZFRGIHF7HY2INZQW36Z5VLZ34BDJPP7742LAWDYIF7LIYDIM6RP55RIPRVIMZEOQWM6JL7YU7AD32MLUPYWY.txt",
    "privacyPolicyLink": "http://www.checkpoint.com/privacy",
    "retrieveDatetime": "2021-04-25T05:14:01.0226883Z",
    "signature":
"WBJPLBZM5FN2JSSURUY7M4LKB73IVQ3ETPIY2NXPX7DCZYZBB64S2EL5YEHQCUYSVNMAHMBYIJ2T7XUUWK7LZIPWG4GAGCCLBVCLBVY",
    "accepted": true // **accepted** true
  }
}
HTTP Method:
GET

Absolute Uri:
https://management.azure.com/subscriptions/ec0aa5f7-9e78-40c9-85cd-535c6305b380/providers/Microsoft.MarketplaceOrdering/offerTypes/virtualmachine/publishers/checkpoint/offers/vsec/plans/management/agreements/current?api-version
=2015-06-01

response body
Body:
{
  "id": "/subscriptions/ec0aa5f7-9e78-40c9-85cd-535c6305b380/providers/Microsoft.MarketplaceOrdering/offerTypes/VirtualMachine/publishers/checkpoint/offers/vsec/plans/management/agreements/current",
  "name": "management",
  "type": "Microsoft.MarketplaceOrdering/offertypes",
  "properties": {
    "publisher": "checkpoint",
    "product": "vsec",
    "plan": "management",
    "licenseTextLink":
"https://mpcprodsa.blob.core.windows.net/legalterms/3E5ED_legalterms_CHECKPOINT%253a24VSEC%253a24MANAGEMENT%253a2476HGNZSJREVLUQYE5WCZFRGIHF7HY2INZQW36Z5VLZ34BDJPP7742LAWDYIF7LIYDIM6RP55RIPRVIMZEOQWM6JL7YU7AD32MLUPYWY.txt",
    "privacyPolicyLink": "http://www.checkpoint.com/privacy",
    "retrieveDatetime": "2021-04-25T05:28:33.0399195Z",
    "signature": "ARDJBLYW4OTTVHIJRLNCK5VNXWWCMMYDPJ2TBMMWGZSLZFU3RKSNGEV6VOML74P3JSTOI4NACCZQIBVQLJATA3QNHXVQSWQ7GXNHS6I",
    "accepted": false
  }
}
ghost commented 3 years ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @prbansa.

Issue Details
2 issues: - MarketplaceOrdering 2021-01-01 PUT APIproviders/Microsoft.MarketplaceOrdering/offerTypes/{offerType}/publishers/{publisher}/offers/{offer}/plans/{plan}/agreements/current return property `accepted` always false even for accepted terms, while same API call with API version with 2015-06-01 returned true. below are detail rest call payload. - Call against 2021-01-01 ``` cli.azure.cli.core.sdk.policies: Request method: 'PUT' cli.azure.cli.core.sdk.policies: Request headers: cli.azure.cli.core.sdk.policies: 'Content-Type': 'application/json' cli.azure.cli.core.sdk.policies: 'Accept': 'application/json' cli.azure.cli.core.sdk.policies: 'Content-Length': '84' cli.azure.cli.core.sdk.policies: Request body: cli.azure.cli.core.sdk.policies: {"properties": {"publisher": "checkpoint", "product": "vsec", "plan": "management"}} urllib3.connectionpool: Starting new HTTPS connection (1): management.azure.com:443 urllib3.connectionpool: https://management.azure.com:443 "PUT /subscriptions/ec0aa5f7-9e78-40c9-85cd-535c6305b380/providers/Microsoft.MarketplaceOrdering/offerTypes/virtualmachine/publishers/checkpoint/offers/vsec/plans/management/agreements/current?api-version=2021-01-01 HTTP/1.1" 200 None cli.azure.cli.core.sdk.policies: Response status: 200 cli.azure.cli.core.sdk.policies: Response headers: cli.azure.cli.core.sdk.policies: 'Cache-Control': 'no-cache' cli.azure.cli.core.sdk.policies: 'Pragma': 'no-cache' cli.azure.cli.core.sdk.policies: 'Transfer-Encoding': 'chunked' cli.azure.cli.core.sdk.policies: 'Content-Type': 'application/json; charset=utf-8' cli.azure.cli.core.sdk.policies: 'Content-Encoding': 'gzip' cli.azure.cli.core.sdk.policies: 'Expires': '-1' cli.azure.cli.core.sdk.policies: 'Vary': 'Accept-Encoding,Accept-Encoding' cli.azure.cli.core.sdk.policies: 'Set-Cookie': Path=/;HttpOnly;Secure;Domain=storeapi.azure.com, Path=/;HttpOnly;SameSite=None;Secure;Domain=storeapi.azure.com' cli.azure.cli.core.sdk.policies: 'Server': 'Microsoft-IIS/10.0' cli.azure.cli.core.sdk.policies: 'X-Powered-By': 'ASP.NET' cli.azure.cli.core.sdk.policies: 'Date': 'Sun, 25 Apr 2021 05:23:53 GMT' cli.azure.cli.core.sdk.policies: Response content: { "accepted": false, "id": "/subscriptions/ec0aa5f7-9e78-40c9-85cd-535c6305b380/providers/Microsoft.MarketplaceOrdering/offerTypes/Microsoft.MarketplaceOrdering/offertypes/publishers/checkpoint/offers/vsec/plans/management/agreements/current", "licenseTextLink": "https://mpcprodsa.blob.core.windows.net/legalterms/3E5ED_legalterms_CHECKPOINT%253a24VSEC%253a24MANAGEMENT%253a2476HGNZSJREVLUQYE5WCZFRGIHF7HY2INZQW36Z5VLZ34BDJPP7742LAWDYIF7LIYDIM6RP55RIPRVIMZEOQWM6JL7YU7AD32MLUPYWY.txt", "marketplaceTermsLink": "https://mpcprodsa.blob.core.windows.net/marketplaceterms/3EDEF_marketplaceterms_AZUREAPPLICATION%253a24OF7TIMHFEMPZHRBYEO3SVLC7Q2MPXXAASJ5BO2FUY4UC6EZCN5TIL2KIGTA7WI2CSM3WV4L7QMPNRYPE2I7BOCM34RGOL3XTC6ADIMI.txt", "name": "management", "plan": "management", "privacyPolicyLink": "http://www.checkpoint.com/privacy", "product": "vsec", "publisher": "checkpoint", "retrieveDatetime": "2021-04-25T05:14:01.0226883Z", "signature": "WBJPLBZM5FN2JSSURUY7M4LKB73IVQ3ETPIY2NXPX7DCZYZBB64S2EL5YEHQCUYSVNMAHMBYIJ2T7XUUWK7LZIPWG4GAGCCLBVCLBVY", "systemData": { "createdAt": "2021-04-25T05:23:53.783067+00:00", "createdBy": "xxxxxxxxxxxxxxxxxxxxxxxxxxxx", "createdByType": "ManagedIdentity", "lastModifiedAt": "2021-04-25T05:23:53.783067+00:00", "lastModifiedBy": "xxxxxxxxxxxxxxxxxxxxx", "lastModifiedByType": "ManagedIdentity" }, "type": "Microsoft.MarketplaceOrdering/offertypes" } ``` - Call against 2015-06-01 ``` HTTP Method: PUT Absolute Uri: https://management.azure.com/subscriptions/ec0aa5f7-9e78-40c9-85cd-535c6305b380/providers/Microsoft.MarketplaceOrdering /offerTypes/virtualmachine/publishers/checkpoint/offers/vsec/plans/management/agreements/current?api-version=2015-06-01 Headers: x-ms-client-request-id : 425cd3a2-9440-4f5a-bb79-1e7085d09a58 accept-language : en-US Body: { "properties": { "publisher": "checkpoint", "product": "vsec", "plan": "management", "licenseTextLink": "https://mpcprodsa.blob.core.windows.net/legalterms/3E5ED_legalterms_CHECKPOINT%253a24VSEC%253a24MANAGEMENT%253a2476HGN ZSJREVLUQYE5WCZFRGIHF7HY2INZQW36Z5VLZ34BDJPP7742LAWDYIF7LIYDIM6RP55RIPRVIMZEOQWM6JL7YU7AD32MLUPYWY.txt", "privacyPolicyLink": "http://www.checkpoint.com/privacy", "retrieveDatetime": "2021-04-25T05:14:01.0226883Z", "signature": "WBJPLBZM5FN2JSSURUY7M4LKB73IVQ3ETPIY2NXPX7DCZYZBB64S2EL5YEHQCUYSVNMAHMBYIJ2T7XUUWK7LZIPWG4GAGCCLBVCLBVY", "accepted": true // **accepted** true } } ``` - Both API Get calls always return accepted as false, no matter the term is accepted or not. ``` HTTP Method: GET Absolute Uri: https://management.azure.com/subscriptions/ec0aa5f7-9e78-40c9-85cd-535c6305b380/providers/Microsoft.MarketplaceOrdering/offerTypes/virtualmachine/publishers/checkpoint/offers/vsec/plans/management/agreements/current?api-version =2015-06-01 response body Body: { "id": "/subscriptions/ec0aa5f7-9e78-40c9-85cd-535c6305b380/providers/Microsoft.MarketplaceOrdering/offerTypes/VirtualMachine/publishers/checkpoint/offers/vsec/plans/management/agreements/current", "name": "management", "type": "Microsoft.MarketplaceOrdering/offertypes", "properties": { "publisher": "checkpoint", "product": "vsec", "plan": "management", "licenseTextLink": "https://mpcprodsa.blob.core.windows.net/legalterms/3E5ED_legalterms_CHECKPOINT%253a24VSEC%253a24MANAGEMENT%253a2476HGNZSJREVLUQYE5WCZFRGIHF7HY2INZQW36Z5VLZ34BDJPP7742LAWDYIF7LIYDIM6RP55RIPRVIMZEOQWM6JL7YU7AD32MLUPYWY.txt", "privacyPolicyLink": "http://www.checkpoint.com/privacy", "retrieveDatetime": "2021-04-25T05:28:33.0399195Z", "signature": "ARDJBLYW4OTTVHIJRLNCK5VNXWWCMMYDPJ2TBMMWGZSLZFU3RKSNGEV6VOML74P3JSTOI4NACCZQIBVQLJATA3QNHXVQSWQ7GXNHS6I", "accepted": false } } ```
Author: yungezz
Assignees: raych1
Labels: `Marketplace Ordering`, `Service Attention`, `needs-triage`
Milestone: -