Azure / azure-rest-api-specs

The source for REST API specifications for Microsoft Azure.
MIT License
2.52k stars 4.95k forks source link

Should Microsoft.ServiceFabricManagedClusters folder be Microsoft.ServiceFabric? #15867

Open mikhailshilkov opened 2 years ago

mikhailshilkov commented 2 years ago

As described in https://github.com/Azure/azure-rest-api-specs#directory-structure, this repo is fairly consistent about the folder structure. In particular, item (4) is a resource provider name. For service fabric managed clusters, the resource provider is still called Microsoft.ServiceFabric (example) while the folder is called Microsoft.ServiceFabricManagedClusters: https://github.com/Azure/azure-rest-api-specs/tree/main/specification/servicefabricmanagedclusters/resource-manager/Microsoft.ServiceFabricManagedClusters

Shall it be renamed to Microsoft.ServiceFabric?

This triggered an error in Pulumi Azure Native provider.

ghost commented 2 years ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @QingChenmsft, @vaishnavk, @juhacket.

Issue Details
As described in https://github.com/Azure/azure-rest-api-specs#directory-structure, this repo is fairly consistent about the folder structure. In particular, item (4) is a resource provider name. For service fabric managed clusters, the resource provider is still called `Microsoft.ServiceFabric` ([example](https://github.com/Azure/azure-rest-api-specs/blob/9816073fe0652b346f5bf328a7ba017efcb7e826/specification/servicefabricmanagedclusters/resource-manager/Microsoft.ServiceFabricManagedClusters/stable/2021-05-01/managedcluster.json#L37)) while the folder is called `Microsoft.ServiceFabricManagedClusters`: https://github.com/Azure/azure-rest-api-specs/tree/main/specification/servicefabricmanagedclusters/resource-manager/Microsoft.ServiceFabricManagedClusters Shall it be renamed to `Microsoft.ServiceFabric`? This triggered an error in [Pulumi Azure Native provider](https://github.com/pulumi/pulumi-azure-native/).
Author: mikhailshilkov
Assignees: leni-msft
Labels: `question`, `Service Fabric`, `Service Attention`, `customer-reported`, `needs-triage`
Milestone: -