Azure / azure-rest-api-specs

The source for REST API specifications for Microsoft Azure.
MIT License
2.53k stars 4.95k forks source link

`Microsoft.MachineLearningServices/workspaces/datastores` PUT body is not RPC-compliant #16216

Open anthony-c-martin opened 2 years ago

anthony-c-martin commented 2 years ago

The PUT request body for this resource type uses DatastoreCreateRequest, which is not compliant as per the ARM RPC: https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/resource-api-reference.md#put-resource

https://github.com/Azure/azure-rest-api-specs/blob/88e7838a09868a51de3894114355c75929847a46/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2020-05-01-preview/machineLearningServices.json#L1992

Should these properties be inside "properties" as part of a resource body definition?

Note - the same issue may exist for other resources defined in this spec.

ghost commented 2 years ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @azureml-github.

Issue Details
The PUT request body for this resource type uses `DatastoreCreateRequest`, which is not compliant as per the ARM RPC: https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/resource-api-reference.md#put-resource https://github.com/Azure/azure-rest-api-specs/blob/88e7838a09868a51de3894114355c75929847a46/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2020-05-01-preview/machineLearningServices.json#L1992 Should these properties be inside "properties" as part of a resource body definition? Note - the same issue may exist for other resources defined in this spec.
Author: anthony-c-martin
Assignees: raych1
Labels: `Machine Learning`, `Service Attention`, `needs-triage`
Milestone: -