Closed bexxx closed 2 years ago
PR forthcoming
uploadSessions
api. customModelWeight
to 20. The team will update the storage section and work off-line with @tg-msft and schedule a review if necessary.
Meeting Chat Meeting Recording
Note: The Teams channel is internal MS.
All minor changes and discussion centered around consistency and where to deviate.
POST
blocks/commit
supported
prefix to the dataset name To resolve the raised comments we did the following two changes:
Block commit route: We are now using POST and make the route datasets/{id}/block/commit, returning a 200 as discussed in the meeting. We saw that for datasets, we did not add the links to the new actions (GET blocks, PUT blocks and POST blocks/commit, this has been added too. Additionally, we are now separating the action "commit" with a ":" instead of "/".
Exposing the supported datasetkinds: Instead of offering a variety of Booleans with a specific naming scheme as proposed, we are simply returning an array of supported dataset kinds, BUT we renamed the properties to be easier to understand (adaptableWithDatasetKinds -> supportsAdaptationsWith). Example:
$baseModel.properties.features.supportsAdaptationsWith = Array[DatasetKind(enum)] $baseModel.properties.features.supportsTranscriptions (bool) $baseModel.properties.features.supportsEndpoints (bool) $baseModel.properties.features.supportsTranscriptionsOnSpeechContainers (bool)
Developers can then write code like if (baseModel.properties.features.adaptableWithDatasetKinds.Contains(myDataset.Kind) > -1) {...} C# or if ($baseModel.properties.features.adaptableWithDatasetKinds.indexOf("language") > -1) {...} JS if ($baseModel.properties.features.adaptableWithDatasetKinds.includes(myDataset.kind)) {...} JS
✅ API Review Board: Signed Off
[Meeting Chat]() Meeting Recording
Some existing features have been extended: