Azure / azure-rest-api-specs

The source for REST API specifications for Microsoft Azure.
MIT License
2.67k stars 5.09k forks source link

[Cognitive - Custom Speech] REST API Review, new version v3.1-preview.1 #18293

Closed bexxx closed 2 years ago

bexxx commented 2 years ago

Some existing features have been extended:

czubair commented 2 years ago

PR forthcoming

markweitzel commented 2 years ago

API Stewardship Board Review Meeting 22-March-22

Discussion / Notes

Actions

Next Steps

The team will update the storage section and work off-line with @tg-msft and schedule a review if necessary.

References

Meeting Chat Meeting Recording

Helpful Documentation

Note: The Teams channel is internal MS.

markweitzel commented 2 years ago

API Stewardship Board Review 31-05-22

All minor changes and discussion centered around consistency and where to deviate.

To resolve the raised comments we did the following two changes:

  1. Block commit route: We are now using POST and make the route datasets/{id}/block/commit, returning a 200 as discussed in the meeting. We saw that for datasets, we did not add the links to the new actions (GET blocks, PUT blocks and POST blocks/commit, this has been added too. Additionally, we are now separating the action "commit" with a ":" instead of "/".

  2. Exposing the supported datasetkinds: Instead of offering a variety of Booleans with a specific naming scheme as proposed, we are simply returning an array of supported dataset kinds, BUT we renamed the properties to be easier to understand (adaptableWithDatasetKinds -> supportsAdaptationsWith). Example:

$baseModel.properties.features.supportsAdaptationsWith = Array[DatasetKind(enum)] $baseModel.properties.features.supportsTranscriptions (bool) $baseModel.properties.features.supportsEndpoints (bool) $baseModel.properties.features.supportsTranscriptionsOnSpeechContainers (bool)

Developers can then write code like if (baseModel.properties.features.adaptableWithDatasetKinds.Contains(myDataset.Kind) > -1) {...} C# or if ($baseModel.properties.features.adaptableWithDatasetKinds.indexOf("language") > -1) {...} JS if ($baseModel.properties.features.adaptableWithDatasetKinds.includes(myDataset.kind)) {...} JS

Next Steps

✅ API Review Board: Signed Off

References

[Meeting Chat]() Meeting Recording